Skip to content

[None][fix] Unwaive Qwen3.5 bf16 mtp on case - #14511

Merged
nv-guomingz merged 1 commit into
NVIDIA:mainfrom
nv-guomingz:user/guomingz/unwaive_nvbug_6205312
May 25, 2026
Merged

[None][fix] Unwaive Qwen3.5 bf16 mtp on case#14511
nv-guomingz merged 1 commit into
NVIDIA:mainfrom
nv-guomingz:user/guomingz/unwaive_nvbug_6205312

Conversation

@nv-guomingz

@nv-guomingz nv-guomingz commented May 25, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Removed a test skip waiver entry, re-enabling a previously disabled test case.

Review Change Stack

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
@nv-guomingz
nv-guomingz force-pushed the user/guomingz/unwaive_nvbug_6205312 branch from 24da623 to 22d2f2a Compare May 25, 2026 04:22
@nv-guomingz

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@coderabbitai

coderabbitai Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

A single SKIP waiver entry is removed from the integration test waiver list. The waived test full:DGX_B200/accuracy/test_llm_api_pytorch.py::TestQwen3_5_35B_A3B::test_bf16_mtp[mtp_on] will now execute in the test suite instead of being skipped.

Changes

Test Waiver Removal

Layer / File(s) Summary
Remove Qwen3.5 BF16 MTP test waiver
tests/integration/test_lists/waives.txt
The SKIP waiver for TestQwen3_5_35B_A3B::test_bf16_mtp[mtp_on] on DGX_B200 is removed, enabling the test to run.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14461: Both PRs remove a single SKIP waiver entry from tests/integration/test_lists/waives.txt for a specific test case.
  • NVIDIA/TensorRT-LLM#14455: Both PRs modify the waiver for the same test_bf16_mtp[mtp_on] test case in the waiver list.
  • NVIDIA/TensorRT-LLM#14341: Both PRs modify tests/integration/test_lists/waives.txt by removing SKIP waiver entries related to MTP tests.

Suggested reviewers

  • ZhanruiSunCh
  • EmmaQiaoCh
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete; all substantive sections (Description, Test Coverage) are empty with only template text provided. Add a brief explanation of why the test waiver was removed and confirm the underlying issue has been resolved or fixed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title '[None][fix] Unwaive Qwen3.5 bf16 mtp on case' clearly describes the main change: removing a test waiver for a specific Qwen3.5 test case.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50141 [ run ] triggered by Bot. Commit: 22d2f2a Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50141 [ run ] completed with state SUCCESS. Commit: 22d2f2a
/LLM/main/L0_MergeRequest_PR pipeline #39691 completed with status: 'SUCCESS'

CI Report

Link to invocation

@nv-guomingz
nv-guomingz enabled auto-merge (squash) May 25, 2026 07:27
@nv-guomingz
nv-guomingz merged commit 5cb6d2d into NVIDIA:main May 25, 2026
12 of 14 checks passed
KleinBlueC pushed a commit to KleinBlueC/TensorRT-LLM that referenced this pull request May 26, 2026
Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
bmarimuthu-nv pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request May 28, 2026
Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants