Skip to content

[https://nvbugs/6156233][test] unwaive GPT-OSS dflash test since bug has been closed as fix unknown#14713

Merged
dongfengy merged 1 commit into
NVIDIA:mainfrom
dongfengy:dongfengy/unwaive-gptoss-dflash
May 29, 2026
Merged

[https://nvbugs/6156233][test] unwaive GPT-OSS dflash test since bug has been closed as fix unknown#14713
dongfengy merged 1 commit into
NVIDIA:mainfrom
dongfengy:dongfengy/unwaive-gptoss-dflash

Conversation

@dongfengy

@dongfengy dongfengy commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Removed a test waiver, enabling a previously skipped test to run again.

Review Change Stack

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
@dongfengy dongfengy changed the title [https://nvbugs/6156233][test] unwaive GPT-OSS dflash test [https://nvbugs/6156233][test] unwaive GPT-OSS dflash test since bug has been closed as fix unknown May 29, 2026
@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This PR removes a single test waiver entry for TestGPTOSS::test_dflash from the integration test waiver list, so that test is no longer skipped.

Changes

Test Waiver Removal

Layer / File(s) Summary
Remove test_dflash waiver entry
tests/integration/test_lists/waives.txt
The waiver entry for accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_dflash is removed from the waiver list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • mzweilz
  • xinhe-nv
  • jieli-matrix
  • schetlur-nv
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description is largely empty with no explanation of the issue, solution, or test coverage details provided despite template sections being present. Fill in the Description section explaining why the test is being unwaived and provide Test Coverage section listing the test case being affected.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing a waiver from a test file that was previously skipped due to a closed bug.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@dongfengy

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "DGX_H100-PyTorch-1, DGX_H100-PyTorch-2, DGX_H100-PyTorch-3, DGX_H100-PyTorch-4, H100_PCIe-PyTorch-Ray-1"

@dongfengy
dongfengy requested a review from ziyixiong-nv May 29, 2026 00:17
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50915 [ run ] triggered by Bot. Commit: 23e0c4d Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50915 [ run ] completed with state SUCCESS. Commit: 23e0c4d
/LLM/main/L0_MergeRequest_PR pipeline #40377 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@dongfengy

Copy link
Copy Markdown
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #51066 [ reuse-pipeline ] triggered by Bot. Commit: 23e0c4d Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #51066 [ reuse-pipeline ] completed with state SUCCESS. Commit: 23e0c4d
Reusing PR_Github #50915 (Partly Tested) for commit 23e0c4d

Link to invocation

@dongfengy
dongfengy merged commit 27b4e56 into NVIDIA:main May 29, 2026
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants