[TRTLLM-13050][test] Remove two-model eagle3 spec-decoding tests - #14735
Conversation
…rom L0 pre-merge Drop the two-model side (eagle3_one_model=False, equivalently the ...-two_model-... parametrization) of the eagle3 speculative-decoding tests from the L0 pre-merge lists, keeping the one-model mirror for each. Removes 17 entries across l0_dgx_b200, l0_dgx_h100, l0_gb200_multi_gpus, and l0_h100, reclaiming ~287 GPU-h/week of pre-merge CI time. The two-model path retains cheaper unit-level coverage and qa/ post-merge entries. Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
|
/bot run |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (4)
📝 WalkthroughWalkthroughThis PR updates test configuration YAML files across multiple GPU hardware setups (DGX B200, DGX H100, GB200, H100) to adjust which Eagle3 model serving test parameterizations run in CI. Changes include transitioning from two-model to one-model overlap scheduler configurations, narrowing disaggregated serving test coverage, and refining accuracy test lists with new fp8 variants and KV cache configurations. ChangesEagle3 Test Configuration Matrix Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #50991 [ run ] triggered by Bot. Commit: |
|
PR_Github #50991 [ run ] completed with state |
Drop the two-model side (eagle3_one_model=False, equivalently the ...-two_model-... parametrization) of the eagle3 speculative-decoding tests from the L0 pre-merge lists, keeping the one-model mirror for each.
Removes 17 entries across l0_dgx_b200, l0_dgx_h100, l0_gb200_multi_gpus, and l0_h100, reclaiming ~287 GPU-h/week of pre-merge CI time. The two-model path retains cheaper unit-level coverage and qa/ post-merge entries.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.