Skip to content

[None][infra] Waive 1 failed cases for main in post-merge 2735 - #14542

Merged
mzweilz merged 1 commit into
NVIDIA:mainfrom
ZhanruiSunCh:trtllm-ci-report/waive-20260526-033014
May 26, 2026
Merged

[None][infra] Waive 1 failed cases for main in post-merge 2735#14542
mzweilz merged 1 commit into
NVIDIA:mainfrom
ZhanruiSunCh:trtllm-ci-report/waive-20260526-033014

Conversation

@ZhanruiSunCh

@ZhanruiSunCh ZhanruiSunCh commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @mzweilz)
Target branch: main
Bug(s): 6220815

Waive entries added

accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_eagle3_4gpus[v1_kv_cache-trtllm-one_model-no_overlap_scheduler] SKIP (https://nvbugs/6220815)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Summary by CodeRabbit

  • Tests
    • Updated test waiver configuration for specific LLM inference scenarios.

Review Change Stack

Bug(s): 6220815
Requested by: @mzweilz

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
@mzweilz

mzweilz commented May 26, 2026

Copy link
Copy Markdown
Collaborator

/bot skip --comment "Waive PR created via CI report, skip testing."

@mzweilz
mzweilz enabled auto-merge (squash) May 26, 2026 03:31
@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

A single waiver entry is added to the integration test skip list for TestGPTOSS::test_eagle3_4gpus under the v1_kv_cache / trtllm / one_model / no_overlap_scheduler configuration, linked to nvbug 6220815.

Changes

Integration Test Waiver

Layer / File(s) Summary
Integration test skip entry
tests/integration/test_lists/waives.txt
Waiver entry added to skip accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_eagle3_4gpus with v1_kv_cache / trtllm / one_model / no_overlap_scheduler configuration, linked to https://nvbugs/6220815.

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14514: Also adds a SKIP waiver for TestGPTOSS::test_eagle3_4gpus but for a different parameter configuration.
  • NVIDIA/TensorRT-LLM#14045: Adds a SKIP waiver entry for TestGPTOSS test cases under v1_kv_cache and trtllm-related configurations.
  • NVIDIA/TensorRT-LLM#14503: Also modifies the same waiver file to add a SKIP entry for the same test under a different parameterization.

Suggested reviewers

  • mzweilz
  • crazydemo

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is missing the standard PR template sections (Description and Test Coverage) and the PR Checklist, though it does provide the essential auto-generated waive information. While auto-generated PRs may not require full descriptions, consider adding a brief Description section explaining why the test is being waived and confirm the Test Coverage section, even if noting that this is an auto-generated waive PR.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly follows the required template format and accurately describes the main change: adding a waive entry for a failed test case in the post-merge verification process.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)

86-86: Waiver entry looks correctly scoped and formatted.

This exact nodeid/config + SKIP (https://nvbugs/6220815) format is appropriate, and no tests/integration/test_lists/qa/* update is needed for this waive-only PR.

As per coding guidelines, waives should match the full pytest nodeid/config and keep the standard SKIP (https://nvbugs/<id>) style.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/integration/test_lists/waives.txt` at line 86, The waiver entry for the
pytest nodeid
accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_eagle3_4gpus[v1_kv_cache-trtllm-one_model-no_overlap_scheduler]
is correctly formatted; do not change it—keep the full pytest nodeid/config and
the "SKIP (https://nvbugs/6220815)" suffix, and do not add any updates to
tests/integration/test_lists/qa/* for this waive-only PR.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 86: The waiver entry for the pytest nodeid
accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_eagle3_4gpus[v1_kv_cache-trtllm-one_model-no_overlap_scheduler]
is correctly formatted; do not change it—keep the full pytest nodeid/config and
the "SKIP (https://nvbugs/6220815)" suffix, and do not add any updates to
tests/integration/test_lists/qa/* for this waive-only PR.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1a3085ea-4b7e-4cd6-b464-1e46264d72c5

📥 Commits

Reviewing files that changed from the base of the PR and between 13778e1 and 437835f.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50264 [ skip ] triggered by Bot. Commit: 437835f Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50263 [ skip ] triggered by Bot. Commit: 437835f Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50264 [ skip ] completed with state ABORTED. Commit: 437835f

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50263 [ skip ] completed with state SUCCESS. Commit: 437835f
Skipping testing for commit 437835f

Link to invocation

@mzweilz
mzweilz merged commit 526d7ee into NVIDIA:main May 26, 2026
12 checks passed
bmarimuthu-nv pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request May 28, 2026
…A#14542)

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants