[None][chore] Waive failing multi-gpu test - #14788
Conversation
Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
📝 WalkthroughWalkthroughA single test waiver entry is added to skip a failing accuracy test case for the Llama 3.1 8B model in the auto-deploy from registry test suite, with a reference to the associated bug. ChangesAccuracy Test Waiver Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
17-17: Coverage status: needs follow-up outside this PR.This waiver line is correctly formatted and should be applied by the waives parser/runtime, but effective coverage for this specific auto-deploy registry path is now temporarily reduced.
Actionable follow-up once
https://nvbugs/6245279is fixed:
tests/integration/accuracy/test_llm_api_autodeploy.py: re-enable/validateTestModelRegistryAccuracy::test_autodeploy_from_registryfornvidia_Llama-3.1-8B-Instruct-NVFP4-True.tests/integration/test_lists/waives.txt: remove this exact SKIP entry in the bug-fix PR.Based on learnings,
tests/integration/test_lists/waives.txtshould use the short nvbug URL format, and this new entry is consistent with that rule.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` at line 17, The waives entry in tests/integration/test_lists/waives.txt correctly skips accuracy/test_llm_api_autodeploy.py::TestModelRegistryAccuracy::test_autodeploy_from_registry for the nvidia_Llama-3.1-8B-Instruct-NVFP4-True case but needs a follow-up when nvbugs/6245279 is fixed: remove that exact SKIP line from tests/integration/test_lists/waives.txt and re-enable/validate the test in tests/integration/accuracy/test_llm_api_autodeploy.py (TestModelRegistryAccuracy::test_autodeploy_from_registry for nvidia_Llama-3.1-8B-Instruct-NVFP4-True) in the bug-fix PR, ensuring the waives file continues using the short nvbug URL format.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 17: The waives entry in tests/integration/test_lists/waives.txt correctly
skips
accuracy/test_llm_api_autodeploy.py::TestModelRegistryAccuracy::test_autodeploy_from_registry
for the nvidia_Llama-3.1-8B-Instruct-NVFP4-True case but needs a follow-up when
nvbugs/6245279 is fixed: remove that exact SKIP line from
tests/integration/test_lists/waives.txt and re-enable/validate the test in
tests/integration/accuracy/test_llm_api_autodeploy.py
(TestModelRegistryAccuracy::test_autodeploy_from_registry for
nvidia_Llama-3.1-8B-Instruct-NVFP4-True) in the bug-fix PR, ensuring the waives
file continues using the short nvbug URL format.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c11537c9-a181-46c9-980f-9eeabb9b56e5
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
d3e37b7 to
632aa28
Compare
|
/bot skip --comment "waive failing test blocking pre-merge" |
|
PR_Github #51203 [ skip ] triggered by Bot. Commit: |
|
PR_Github #51203 [ skip ] completed with state |
Description
Waive failing test blocking pre-merge.
Test Coverage
N/A
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Summary by CodeRabbit