[https://nvbugs/6211189][fix] Lower the reference to 46.5 (matching cross-GPU empirical mean) and remove the t#14799
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR updates the MMMU accuracy baseline for EXAONE-4.5-33B from 51.22 to 46.5 with empirical measurement notes, and removes two corresponding test waivers from the skip list to reflect the corrected expectation. ChangesEXAONE-4.5-33B Test Expectations
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
1e03c39 to
5244922
Compare
|
/bot run |
|
PR_Github #52167 [ run ] triggered by Bot. Commit: |
|
PR_Github #52167 [ run ] completed with state
|
|
/bot run |
|
PR_Github #52298 [ run ] triggered by Bot. Commit: |
|
PR_Github #52298 [ run ] completed with state
|
|
/bot run |
|
PR_Github #52405 [ run ] triggered by Bot. Commit: |
|
PR_Github #52405 [ run ] completed with state
|
…served score The MMMU reference for LGAI-EXAONE/EXAONE-4.5-33B was set to 51.22 in PR NVIDIA#12873 but never validated by pre-merge CI -- the test was added directly to the QA test list, so the bogus reference was never caught. The model in fact scores ~46.5 on every GPU we run it on (H20, B200, B300, GB200, GB300), and the bug confirms "PASSED commit: N/A": the test has never passed since the day it was added. Drop the reference from 51.22 to 46.5 (matches the cross-GPU empirical mean 46.444-46.778) and remove the two waiver entries that were suppressing both parametrize variants. Verified locally on GB300: both full_budget (eval=46.444) and forced_chunked_prefill variants pass against the new threshold (42.623). Run wall time 39 min. Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
5244922 to
cf4d966
Compare
|
/bot run |
|
PR_Github #52814 [ run ] triggered by Bot. Commit: |
|
PR_Github #52814 [ run ] completed with state
|
|
/bot run |
|
PR_Github #52862 [ run ] triggered by Bot. Commit: |
|
PR_Github #52862 [ run ] completed with state |
…ross-GPU empirical mean) and remove the t (NVIDIA#14799) Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Summary
Test plan
Links
Summary by CodeRabbit
Tests
Chores