[None][test] Waive 7 failed cases for main in QA CI - #14791
Conversation
Bug(s): 6059036, 6211193, 6223556, 6241842, 6241845, 6245651 Requested by: qa@nvidia.com Jenkins build: https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_FUNCTION_CLUSTER_TEST/1483/ Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
|
/bot run --skip-test |
📝 WalkthroughWalkthroughThis pull request adds ten test waiver (SKIP) entries to ChangesTest Waivers
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
6-9: QA assessment: Test coverage impact and follow-up recommendations.This PR waivers 10 integration test failures across critical functionality areas:
Affected test areas:
- Disaggregated serving: 5 tests (Gemma dtype/kv_cache, Llama ngram, TinyLlama overlap)
- NVFP4 quantization: 2 tests (DeepSeekV32 multi-GPU variants)
- Autodeploy/registry: 1 test (Gemma model deployment)
- Multi-node service discovery: 1 test (etcd backend)
- Overlap generation router: 1 test (TinyLlama context pipeline parallelism)
Recommendations:
- Track bug resolution timeline: Monitor associated bugs (6059036, 6117811, 6211193, 6223556, 6241842, 6241845, 6245651) to ensure timely fixes
- Verify coverage gaps: Confirm alternative test coverage exists for waived functionality, especially for:
- Gemma 3.1B Instruct dtype handling and KV cache v2
- DeepSeekV32 NVFP4 multi-GPU configurations
- Disaggregated overlap generation routing
- Monitor waive list growth: Consider establishing metrics for total waived tests and maximum waive duration
Coverage assessment: Coverage is insufficient for disaggregated serving (multiple Gemma/Llama waivers) and multi-GPU NVFP4 quantization. Suggest prioritizing bug fixes for 6117811 (affects 3 tests) and 6241842/6241845 (DeepSeek multi-GPU).
Based on learnings, all nvbug URL formats are consistent (short form).
Also applies to: 19-19, 37-38, 172-173, 305-305
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` around lines 6 - 9, The waives file lists skipped integration tests but lacks per-entry rationale, tracking metadata, and coverage-impact grouping; update the waives list entries for each skipped test (e.g., accuracy/test_disaggregated_serving.py::TestGemma3_1BInstruct::test_auto_dtype, ::test_kv_cache_v2_nixl_python, accuracy/test_disaggregated_serving.py::TestLlama3_1_8BInstruct::test_ngram, DeepSeekV32 multi-GPU entries) to include the NV bug IDs, date added, owner/responsible engineer, and brief impact note; also add a summary header that tallies waived tests by category (disaggregated serving, NVFP4 quantization, autodeploy/registry, multi-node discovery, overlap router) and a TODO to re-run/reevaluate after bug fixes so reviewers can track waiver growth and duration.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 6-8: PR description claims "Waive 7 failed cases" but the diff
adds 10 waivers including three Gemma entries referencing bug 6117811
(TestGemma3_1BInstruct::test_auto_dtype[False],
TestGemma3_1BInstruct::test_auto_dtype[True],
TestGemma3_1BInstruct::test_kv_cache_v2_nixl_python in
tests/integration/test_lists/waives.txt); either update the PR title/body to
list all 10 waived tests and mention bug 6117811 covers these three, or remove
those three lines if they were added by mistake, and before finalizing confirm
QA that bug 6117811 indeed applies to all three Gemma failures.
---
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 6-9: The waives file lists skipped integration tests but lacks
per-entry rationale, tracking metadata, and coverage-impact grouping; update the
waives list entries for each skipped test (e.g.,
accuracy/test_disaggregated_serving.py::TestGemma3_1BInstruct::test_auto_dtype,
::test_kv_cache_v2_nixl_python,
accuracy/test_disaggregated_serving.py::TestLlama3_1_8BInstruct::test_ngram,
DeepSeekV32 multi-GPU entries) to include the NV bug IDs, date added,
owner/responsible engineer, and brief impact note; also add a summary header
that tallies waived tests by category (disaggregated serving, NVFP4
quantization, autodeploy/registry, multi-node discovery, overlap router) and a
TODO to re-run/reevaluate after bug fixes so reviewers can track waiver growth
and duration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: fd498774-3b2f-4d99-9c14-41f1f8c112d8
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
|
/bot run --skip-test |
|
PR_Github #51328 [ run ] triggered by Bot. Commit: |
|
PR_Github #51328 [ run ] completed with state |
|
/bot reuse-pipeline |
|
/bot reuse-pipeline |
1 similar comment
|
/bot reuse-pipeline |
|
/bot reuse-pipeline |
|
/bot reuse-pipeline |
|
/bot reuse-pipeline |
|
/bot reuse-pipeline |
|
PR_Github #51461 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #51461 [ reuse-pipeline ] completed with state |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by qa@nvidia.com)
Target branch:
mainJenkins build: https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_FUNCTION_CLUSTER_TEST/1483/
Bug(s): 6059036, 6211193, 6223556, 6241842, 6241845, 6245651
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit
Tests