Skip to content

[https://nvbugs/6260907][fix] unwaive test#15058

Merged
bo-nv merged 1 commit into
NVIDIA:mainfrom
bo-nv:unwaive-6260907
Jun 8, 2026
Merged

[https://nvbugs/6260907][fix] unwaive test#15058
bo-nv merged 1 commit into
NVIDIA:mainfrom
bo-nv:unwaive-6260907

Conversation

@bo-nv

@bo-nv bo-nv commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Re-enabled a previously skipped test case to ensure proper validation of auto dtype functionality.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Bo Deng <deemod@nvidia.com>
@bo-nv

bo-nv commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --skip-test --extra-stage "DGX_B200-8_GPUs-PyTorch-3"

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR removes a single test waiver entry for the TestQwen3NextInstruct::test_auto_dtype[use_py_transceiver=True] test case from the integration test waivers list, allowing this disaggregated serving accuracy test to execute instead of being skipped.

Changes

Test Waiver Removal

Layer / File(s) Summary
Remove QWen3NextInstruct transceiver dtype test waiver
tests/integration/test_lists/waives.txt
Removed the test waiver entry for TestQwen3NextInstruct::test_auto_dtype[use_py_transceiver=True] from the disaggregated serving accuracy test waivers.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14870: Both PRs modify the same integration waiver file (tests/integration/test_lists/waives.txt) by removing specific accuracy-test entries to stop those cases from being skipped.
  • NVIDIA/TensorRT-LLM#14791: Both PRs modify the same tests/integration/test_lists/waives.txt file to add/remove SKIP waiver entries for integration tests.
  • NVIDIA/TensorRT-LLM#14854: Both PRs modify the same tests/integration/test_lists/waives.txt file to adjust waiver entries for specific integration test cases.

Suggested reviewers

  • EmmaQiaoCh
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete. While the title is provided, the Description and Test Coverage sections are empty, and the checklist is marked but contains no additional context. Fill in the Description section explaining why the test waiver was removed, complete the Test Coverage section, and provide any relevant context for the change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format with a valid NVBugs ID, fix type, and clearly describes the main change: removing a test waiver.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@bo-nv
bo-nv requested review from EmmaQiaoCh and ZhanruiSunCh June 7, 2026 09:26
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52568 [ run ] triggered by Bot. Commit: fee0f93 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52568 [ run ] completed with state SUCCESS. Commit: fee0f93
/LLM/main/L0_MergeRequest_PR pipeline #41851 (Partly Tested) completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

CI Report

Link to invocation

@bo-nv

bo-nv commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52587 [ run ] triggered by Bot. Commit: fee0f93 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52587 [ run ] completed with state SUCCESS. Commit: fee0f93
/LLM/main/L0_MergeRequest_PR pipeline #41869 completed with status: 'SUCCESS'

CI Report

Link to invocation

@bo-nv
bo-nv enabled auto-merge (squash) June 8, 2026 01:21
@bo-nv
bo-nv merged commit 8be182d into NVIDIA:main Jun 8, 2026
13 of 15 checks passed
2ez4bz pushed a commit to 2ez4bz/TensorRT-LLM that referenced this pull request Jun 8, 2026
Signed-off-by: Bo Deng <deemod@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants