Skip to content

[https://nvbugs/6153955][test] unwaive GPT-OSS w4 DP4 CUTLASS - #14884

Merged
dongfengy merged 1 commit into
NVIDIA:mainfrom
dongfengy:unwaive-gptoss-w4-dp4-cutlass
Jun 8, 2026
Merged

[https://nvbugs/6153955][test] unwaive GPT-OSS w4 DP4 CUTLASS#14884
dongfengy merged 1 commit into
NVIDIA:mainfrom
dongfengy:unwaive-gptoss-w4-dp4-cutlass

Conversation

@dongfengy

@dongfengy dongfengy commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Test no longer flaky

Summary by CodeRabbit

  • Tests
    • Removed a test skip waiver, allowing a previously skipped test to resume execution.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
@dongfengy
dongfengy requested review from jieli-matrix and mzweilz June 3, 2026 02:39
@dongfengy
dongfengy marked this pull request as ready for review June 3, 2026 02:39
@dongfengy

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "GB200-4_GPUs-PyTorch-2"

@dongfengy dongfengy changed the title [None][test] unwaive GPT-OSS w4 DP4 CUTLASS [https://nvbugs/6153955][test] unwaive GPT-OSS w4 DP4 CUTLASS Jun 3, 2026
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Removes a single SKIP waiver entry from tests/integration/test_lists/waives.txt for the TestGPTOSS::test_w4_4gpus[v1_kv_cache-dp4-cutlass-auto] test configuration, allowing it to run in the test suite.

Changes

Test Waiver Removal

Layer / File(s) Summary
Remove GPTOSS w4_4gpus test waiver
tests/integration/test_lists/waives.txt
Deleted the SKIP waiver entry for accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_w4_4gpus[v1_kv_cache-dp4-cutlass-auto], corresponding to issue https://nvbugs/6153955.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • jieli-matrix
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description is largely empty, containing only template boilerplate with no substantive content about the changes, rationale, or test coverage. Add a clear description explaining why the test waiver was removed, what the underlying issue was, and confirm the test is no longer flaky. Include relevant test coverage details and link to any related issues.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The PR title directly describes the main change: removing a waiver for a specific test case (GPT-OSS w4 DP4 CUTLASS), matching the file modification in waives.txt.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #51735 [ run ] triggered by Bot. Commit: 10d5dc6 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #51735 [ run ] completed with state SUCCESS. Commit: 10d5dc6
/LLM/main/L0_MergeRequest_PR pipeline #41108 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@dongfengy

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "the stage that has the test has passed"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52654 [ skip ] triggered by Bot. Commit: 10d5dc6 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52654 [ skip ] completed with state SUCCESS. Commit: 10d5dc6
Skipping testing for commit 10d5dc6

Link to invocation

@dongfengy
dongfengy merged commit b4d44d3 into NVIDIA:main Jun 8, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants