[https://nvbugs/6248744][fix] Added `trust_remote_code=True` to the `LLM(...)` constructor and removed the… by tensorrt-cicd · Pull Request #14892 · NVIDIA/TensorRT-LLM

tensorrt-cicd · 2026-06-03T06:07:31Z

Summary

Root cause: PR [https://nvbugs/5996024][fix] Enforce trust_remote_code flag #13527 made the loader honor llm_args.trust_remote_code (default False), but TestNemotron_Nano_12B_V2_VL omits trust_remote_code=True, and the model ships custom HF code requiring it.
Fix: Added trust_remote_code=True to the LLM(...) constructor and removed the obsolete waiver; verify run passed (1 passed, MMMU 26.56 vs ref 26.67).
Automated fix generated by repair-bot

Test plan

Verify fix on the same GPU type as the original failure
Check for regressions in related tests

Links

Bug: https://nvbugs/6248744

Summary by CodeRabbit

Tests
- Re-enabled a previously skipped test case for multimodal LLM model compatibility, ensuring proper handling of remote code execution scenarios.

coderabbitai · 2026-06-03T06:10:02Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b643ccb4-a450-4086-a31a-3a8f714e6472

📥 Commits

Reviewing files that changed from the base of the PR and between d0cfcde and a82a0ee.

📒 Files selected for processing (2)

tests/integration/defs/accuracy/test_llm_api_pytorch_multimodal.py
tests/integration/test_lists/waives.txt

💤 Files with no reviewable changes (1)

tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

This PR enables a previously-waived multimodal LLM test by adding the trust_remote_code=True parameter to the test's LLM constructor and removing the corresponding waive entry, allowing the test to run instead of being skipped.

Changes

Test Recovery for Nemotron Nano 12B V2 VL

Layer / File(s)	Summary
Enable test with remote code trust parameter and waive removal `tests/integration/defs/accuracy/test_llm_api_pytorch_multimodal.py`, `tests/integration/test_lists/waives.txt`	`TestNemotron_Nano_12B_V2_VL.test_auto_dtype` now passes `trust_remote_code=True` to the `LLM` constructor, and the waive entry for `test_auto_dtype[forced_chunked_prefill]` is removed so the test executes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

NVIDIA/TensorRT-LLM#14545: Also modifies tests/integration/test_lists/waives.txt by removing waived test entries.
NVIDIA/TensorRT-LLM#14854: Also modifies tests/integration/test_lists/waives.txt to update the set of skipped/waived integration test entries.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title correctly identifies the main change: adding trust_remote_code=True and removing a waiver. It references the bug ticket and uses appropriate [fix] type designation.
Description check	✅ Passed	The PR description clearly explains the root cause (PR `#13527` behavior change), the fix applied, verification results, and includes test coverage confirmation. However, it is missing the standard template structure with explicit Description and Test Coverage sections.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

longlee0622 · 2026-06-03T10:18:25Z

/bot run

tensorrt-cicd · 2026-06-03T10:24:40Z

PR_Github #51824 [ run ] triggered by Bot. Commit: 8f3594e Link to invocation

tensorrt-cicd · 2026-06-03T11:50:26Z

PR_Github #51824 [ run ] completed with state SUCCESS. Commit: 8f3594e
/LLM/main/L0_MergeRequest_PR pipeline #41187 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

yibinl-nvidia · 2026-06-03T23:51:22Z

/bot run

tensorrt-cicd · 2026-06-03T23:57:55Z

PR_Github #51921 [ run ] triggered by Bot. Commit: 8f3594e Link to invocation

tensorrt-cicd · 2026-06-04T00:38:24Z

PR_Github #51921 [ run ] completed with state FAILURE. Commit: 8f3594e
/LLM/main/L0_MergeRequest_PR pipeline #41275 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

yibinl-nvidia · 2026-06-04T15:12:32Z

/bot run

tensorrt-cicd · 2026-06-04T15:19:06Z

PR_Github #52097 [ run ] triggered by Bot. Commit: 8f3594e Link to invocation

tensorrt-cicd · 2026-06-04T16:26:56Z

PR_Github #52097 [ run ] completed with state SUCCESS. Commit: 8f3594e
/LLM/main/L0_MergeRequest_PR pipeline #41427 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

yibinl-nvidia · 2026-06-04T16:28:23Z

/bot run

tensorrt-cicd · 2026-06-04T16:41:35Z

PR_Github #52108 [ run ] triggered by Bot. Commit: 8f3594e Link to invocation

tensorrt-cicd · 2026-06-05T04:14:53Z

PR_Github #52108 [ run ] completed with state SUCCESS. Commit: 8f3594e
/LLM/main/L0_MergeRequest_PR pipeline #41438 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

…V2 VL test Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>

Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>

yibinl-nvidia · 2026-06-05T15:24:09Z

/bot run

tensorrt-cicd · 2026-06-05T15:32:29Z

PR_Github #52364 [ run ] triggered by Bot. Commit: b8869f2 Link to invocation

tensorrt-cicd · 2026-06-05T16:19:51Z

PR_Github #52364 [ run ] completed with state SUCCESS. Commit: b8869f2
/LLM/main/L0_MergeRequest_PR pipeline #41661 completed with status: 'SUCCESS'

CI Report

Link to invocation

…LLM(...)` constructor and removed the… (NVIDIA#14892) Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com> Signed-off-by: NVFB <186336021+NVFB@users.noreply.github.com>

…LLM(...)` constructor and removed the… (NVIDIA#14892) Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>

tensorrt-cicd requested review from a team as code owners June 3, 2026 06:07

tensorrt-cicd requested review from moraxu and tijyojwad June 3, 2026 06:07

tensorrt-cicd assigned yibinl-nvidia Jun 3, 2026

github-actions Bot assigned tensorrt-cicd Jun 3, 2026

moraxu approved these changes Jun 3, 2026

View reviewed changes

longlee0622 force-pushed the repair-bot-bug6248744 branch from a82a0ee to 8f3594e Compare June 3, 2026 10:18

xinhe-nv approved these changes Jun 4, 2026

View reviewed changes

tensorrt-cicd added 2 commits June 5, 2026 07:50

[nvbugs/6248744][fix] Enable trust_remote_code for Nemotron Nano 12B …

7f0a5ea

…V2 VL test Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>

[nvbugs/6248744][chore] Remove stale waiver after fix

b8869f2

Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>

tensorrt-cicd force-pushed the repair-bot-bug6248744 branch from 8f3594e to b8869f2 Compare June 5, 2026 14:52

yibinl-nvidia merged commit 501b5c2 into NVIDIA:main Jun 5, 2026
7 checks passed

coderabbitai Bot mentioned this pull request Jun 8, 2026

[None][fix] Fix and unwaive nemotron related bugs #15085

Merged

1 task

Uh oh!

Conversation

tensorrt-cicd commented Jun 3, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Links

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 3, 2026

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

❌ Failed checks (1 warning)

Uh oh!

longlee0622 commented Jun 3, 2026

Uh oh!

tensorrt-cicd commented Jun 3, 2026

Uh oh!

tensorrt-cicd commented Jun 3, 2026

Uh oh!

yibinl-nvidia commented Jun 3, 2026

Uh oh!

tensorrt-cicd commented Jun 3, 2026

Uh oh!

tensorrt-cicd commented Jun 4, 2026

Uh oh!

yibinl-nvidia commented Jun 4, 2026

Uh oh!

tensorrt-cicd commented Jun 4, 2026

Uh oh!

tensorrt-cicd commented Jun 4, 2026

Uh oh!

yibinl-nvidia commented Jun 4, 2026

Uh oh!

tensorrt-cicd commented Jun 4, 2026

Uh oh!

tensorrt-cicd commented Jun 5, 2026

Uh oh!

yibinl-nvidia commented Jun 5, 2026

Uh oh!

tensorrt-cicd commented Jun 5, 2026

Uh oh!

tensorrt-cicd commented Jun 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tensorrt-cicd commented Jun 3, 2026 •

edited by coderabbitai Bot

Loading