Skip to content

[https://nvbugs/5859886][fix] Remove the waiver - #14948

Merged
ziyixiong-nv merged 1 commit into
NVIDIA:mainfrom
ziyixiong-nv:dev-fxiong-bug5859886
Jun 5, 2026
Merged

[https://nvbugs/5859886][fix] Remove the waiver#14948
ziyixiong-nv merged 1 commit into
NVIDIA:mainfrom
ziyixiong-nv:dev-fxiong-bug5859886

Conversation

@ziyixiong-nv

@ziyixiong-nv ziyixiong-nv commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Removed a test waiver entry, allowing the corresponding test case to run again.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@ziyixiong-nv

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR removes a single waived test entry from the integration test skip list for a DeepSeekV32 FP8 blockscale test case with the disable_skip_indexer parameter. The test is no longer marked as skipped and will run in the test suite.

Changes

Test Waiver Removal

Layer / File(s) Summary
Waive entry removal
tests/integration/test_lists/waives.txt
Removed the waived entry for accuracy/test_llm_api_pytorch.py::TestDeepSeekV32::test_fp8_blockscale[disable_skip_indexer], enabling the test to run.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14545: Both PRs modify the same waiver file by removing SKIP entries for DeepSeekV32 test_fp8_blockscale configurations.
  • NVIDIA/TensorRT-LLM#13647: Both PRs modify the waiver list by removing waived entries for DeepSeek-related integration test cases.
  • NVIDIA/TensorRT-LLM#14866: Both PRs update the same waiver list file by removing/adjusting pytest SKIP entries for accuracy test cases.

Suggested reviewers

  • xinhe-nv
  • leslie-fang25
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely empty—only the template is present with no filled-in sections for Description, Test Coverage, or rationale for removing the waiver. Fill in the Description section explaining why the waiver was removed (e.g., the underlying issue was fixed), and clarify Test Coverage to confirm the test now passes without waiver.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly follows the required format [NVBugs ID][type] and directly describes the main change: removing a waiver entry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52015 [ run ] triggered by Bot. Commit: c117466 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52015 [ run ] completed with state SUCCESS. Commit: c117466
/LLM/main/L0_MergeRequest_PR pipeline #41357 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@ziyixiong-nv

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52214 [ run ] triggered by Bot. Commit: c117466 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52214 [ run ] completed with state SUCCESS. Commit: c117466
/LLM/main/L0_MergeRequest_PR pipeline #41533 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@ziyixiong-nv

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52238 [ run ] triggered by Bot. Commit: c117466 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52238 [ run ] completed with state SUCCESS. Commit: c117466
/LLM/main/L0_MergeRequest_PR pipeline #41553 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
@ziyixiong-nv
ziyixiong-nv force-pushed the dev-fxiong-bug5859886 branch from c117466 to fb2e139 Compare June 5, 2026 05:15
@ziyixiong-nv

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52256 [ run ] triggered by Bot. Commit: fb2e139 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52256 [ run ] completed with state SUCCESS. Commit: fb2e139
/LLM/main/L0_MergeRequest_PR pipeline #41570 completed with status: 'SUCCESS'

CI Report

Link to invocation

@ziyixiong-nv
ziyixiong-nv enabled auto-merge (squash) June 5, 2026 12:33
@ziyixiong-nv
ziyixiong-nv merged commit fb5bd44 into NVIDIA:main Jun 5, 2026
10 of 11 checks passed
fbxai pushed a commit to fbxai/TensorRT-LLM that referenced this pull request Jun 5, 2026
Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
Signed-off-by: NVFB <186336021+NVFB@users.noreply.github.com>
2ez4bz pushed a commit to 2ez4bz/TensorRT-LLM that referenced this pull request Jun 8, 2026
Signed-off-by: ziyixiong-nv <219238287+ziyixiong-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants