Skip to content

[None] [waive] Waive the failed step3p7 test case due to ckpt update - #14997

Merged
kaiyux merged 2 commits into
NVIDIA:mainfrom
kaiyux:user/kaiyu/waive_failed_step3p7
Jun 5, 2026
Merged

[None] [waive] Waive the failed step3p7 test case due to ckpt update#14997
kaiyux merged 2 commits into
NVIDIA:mainfrom
kaiyux:user/kaiyu/waive_failed_step3p7

Conversation

@kaiyux

@kaiyux kaiyux commented Jun 5, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Tests
    • Added a test case to the skip/waiver list for compatibility assessment purposes.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
@kaiyux

kaiyux commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

/bot skip --comment "waive test case"

@kaiyux
kaiyux enabled auto-merge (squash) June 5, 2026 06:42
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds a single waiver entry to the integration test skip list for a Step3p7 checkpoint test case related to weight accounting with NVFP4 quantization.

Changes

Test Waiver Addition

Layer / File(s) Summary
Step3p7 checkpoint weight accounting test waiver
tests/integration/test_lists/waives.txt
A SKIP waiver entry is added for the test_config_and_weight_accounting_1_nvfp4 test in the Step3p7 checkpoint test suite.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • jieli-matrix
  • LarryXFly
  • StanleySun639
  • xinhe-nv
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description lacks essential details. Only the template is present with empty sections; no explanation of the issue, checkpoint update, or waiver justification is provided. Fill in the Description section explaining why the test was failing, what checkpoint changed, and why waiving is appropriate. Complete Test Coverage section.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: waiving a failed step3p7 test case due to a checkpoint update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 325: The waiver entry for the test
"unittest/_torch/modeling/test_modeling_step3p7.py::TestStep3p7Checkpoint::test_config_and_weight_accounting_1_nvfp4"
is missing the required SKIP marker and reason, so update the line in
tests/integration/test_lists/waives.txt to include "SKIP (reason)" with a brief
rationale and preferred NV bug reference (e.g., "SKIP (flake - see
https://nvbugs/XXXX)"); ensure the format matches other entries exactly so the
parser will apply it.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f1959e48-c986-4f6b-9e7a-ac0ca4742284

📥 Commits

Reviewing files that changed from the base of the PR and between 21ffdc7 and 3dde569.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Comment thread tests/integration/test_lists/waives.txt Outdated
Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
@kaiyux

kaiyux commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

/bot skip --comment "waive test case"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52283 [ skip ] triggered by Bot. Commit: 74be74d Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52285 [ skip ] triggered by Bot. Commit: 74be74d Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52283 [ skip ] completed with state ABORTED. Commit: 74be74d

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52285 [ skip ] completed with state SUCCESS. Commit: 74be74d
Skipping testing for commit 74be74d

Link to invocation

@kaiyux
kaiyux merged commit 316430f into NVIDIA:main Jun 5, 2026
9 of 10 checks passed
@kaiyux
kaiyux deleted the user/kaiyu/waive_failed_step3p7 branch June 5, 2026 06:59
kaiyux added a commit to kaiyux/TensorRT-LLM that referenced this pull request Jun 5, 2026
fbxai pushed a commit to fbxai/TensorRT-LLM that referenced this pull request Jun 5, 2026
…VIDIA#14997)

Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
Signed-off-by: NVFB <186336021+NVFB@users.noreply.github.com>
kaiyux added a commit to kaiyux/TensorRT-LLM that referenced this pull request Jun 8, 2026
kaiyux added a commit to kaiyux/TensorRT-LLM that referenced this pull request Jun 8, 2026
2ez4bz pushed a commit to 2ez4bz/TensorRT-LLM that referenced this pull request Jun 8, 2026
…VIDIA#14997)

Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
kaiyux added a commit to kaiyux/TensorRT-LLM that referenced this pull request Jun 9, 2026
kaiyux added a commit to kaiyux/TensorRT-LLM that referenced this pull request Jun 9, 2026
kaiyux added a commit to kaiyux/TensorRT-LLM that referenced this pull request Jun 9, 2026
kaiyux added a commit to kaiyux/TensorRT-LLM that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants