[None] [waive] Waive the failed step3p7 test case due to ckpt update - #14997
Conversation
Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
|
/bot skip --comment "waive test case" |
📝 WalkthroughWalkthroughThis PR adds a single waiver entry to the integration test skip list for a Step3p7 checkpoint test case related to weight accounting with NVFP4 quantization. ChangesTest Waiver Addition
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 325: The waiver entry for the test
"unittest/_torch/modeling/test_modeling_step3p7.py::TestStep3p7Checkpoint::test_config_and_weight_accounting_1_nvfp4"
is missing the required SKIP marker and reason, so update the line in
tests/integration/test_lists/waives.txt to include "SKIP (reason)" with a brief
rationale and preferred NV bug reference (e.g., "SKIP (flake - see
https://nvbugs/XXXX)"); ensure the format matches other entries exactly so the
parser will apply it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f1959e48-c986-4f6b-9e7a-ac0ca4742284
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
/bot skip --comment "waive test case" |
|
PR_Github #52283 [ skip ] triggered by Bot. Commit: |
|
PR_Github #52285 [ skip ] triggered by Bot. Commit: |
|
PR_Github #52283 [ skip ] completed with state |
|
PR_Github #52285 [ skip ] completed with state |
… update (NVIDIA#14997)" This reverts commit 316430f.
…VIDIA#14997) Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com> Signed-off-by: NVFB <186336021+NVFB@users.noreply.github.com>
… update (NVIDIA#14997)" This reverts commit 316430f.
… update (NVIDIA#14997)" This reverts commit 316430f.
…VIDIA#14997) Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
… update (NVIDIA#14997)" This reverts commit 316430f.
… update (NVIDIA#14997)" This reverts commit 316430f.
… update (NVIDIA#14997)" This reverts commit 316430f.
… update (NVIDIA#14997)" This reverts commit 316430f.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.