[None][test] update bug ids in waives - #14946
Conversation
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
|
/bot run --stage-list "" |
📝 WalkthroughWalkthroughUpdates to ChangesTest waiver NVBug reference updates
🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
45-48: QA coverage status: sufficient for this waiver-metadata PR; needs follow-up outside this PR for unwaive readiness.For this PR scope (bug-id refresh in
tests/integration/test_lists/waives.txt), coverage is sufficient because no executable test content changed.
Follow-up outside this PR (when each NVBug is resolved): updatetests/integration/test_lists/waives.txtby removing/adjusting these exact entries and re-run the affected suites inaccuracy/test_llm_api_pytorch.pyfor:
TestDeepSeekV3Lite::test_bfloat16_4gpusvariants (Line 45-48)TestDeepSeekV3Lite::test_fp8_block_scales_4gpusvariants (Line 53-56)TestDeepSeekV3Lite::test_nvfp4_4gpusCUTLASS variants (Line 64-66)TestLlama3_1_8BInstruct::test_bfloat16_4gpus/test_fp8_4gpusvariants (Line 93, Line 98)Based on learnings: In
tests/integration/test_lists/waives.txt, the short nvbug URL formathttps://nvbugs/XXXXis preferred and is correctly used here.Also applies to: 53-56, 64-66, 93-93, 98-98
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` around lines 45 - 48, Waiver entries for TestDeepSeekV3Lite::test_bfloat16_4gpus (and other listed variants) in tests/integration/test_lists/waives.txt are temporary and must be updated once the referenced NVBugs are fixed: remove or adjust the exact entries matching accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_bfloat16_4gpus (Lines 45-48), accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_fp8_block_scales_4gpus (Lines 53-56), accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_nvfp4_4gpus (Lines 64-66), and accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_bfloat16_4gpus / test_fp8_4gpus (Lines 93,98) after the corresponding NVBugs are resolved; then re-run the affected suites in accuracy/test_llm_api_pytorch.py to confirm tests can be unwaived, and keep using the short nvbug URL format (https://nvbugs/XXXX) when editing waives.txt.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 45-48: Waiver entries for TestDeepSeekV3Lite::test_bfloat16_4gpus
(and other listed variants) in tests/integration/test_lists/waives.txt are
temporary and must be updated once the referenced NVBugs are fixed: remove or
adjust the exact entries matching
accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_bfloat16_4gpus (Lines
45-48),
accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_fp8_block_scales_4gpus
(Lines 53-56),
accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_nvfp4_4gpus (Lines
64-66), and
accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_bfloat16_4gpus /
test_fp8_4gpus (Lines 93,98) after the corresponding NVBugs are resolved; then
re-run the affected suites in accuracy/test_llm_api_pytorch.py to confirm tests
can be unwaived, and keep using the short nvbug URL format (https://nvbugs/XXXX)
when editing waives.txt.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: a3f332da-61c5-4104-a813-ea82a12b9e95
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
PR_Github #52002 [ run ] triggered by Bot. Commit: |
|
PR_Github #52002 [ run ] completed with state |
|
/bot reuse-pipeline |
|
PR_Github #52021 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #52021 [ reuse-pipeline ] completed with state |
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com> Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.