Skip to content

[https://nvbugs/6162940][chore] Unwaive fixed test#15078

Merged
longlee0622 merged 1 commit into
NVIDIA:mainfrom
longlee0622:unwaive-fixed-test
Jun 8, 2026
Merged

[https://nvbugs/6162940][chore] Unwaive fixed test#15078
longlee0622 merged 1 commit into
NVIDIA:mainfrom
longlee0622:unwaive-fixed-test

Conversation

@longlee0622

@longlee0622 longlee0622 commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

Tests

  • Removed a test waiver, enabling a previously skipped test case for improved test coverage.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Jonas Li <6110159+longlee0622@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR removes a single test waiver entry from the integration test skip list. The skipped test accuracy/test_cli_flow.py::TestGptNext::test_auto_dtype (referenced as nvbugs/6162940) is no longer excluded from test execution.

Changes

Test Waiver Update

Layer / File(s) Summary
Remove test_auto_dtype from waive list
tests/integration/test_lists/waives.txt
The waiver entry for accuracy/test_cli_flow.py::TestGptNext::test_auto_dtype is deleted, re-enabling the test for execution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • EmmaQiaoCh
  • nvchenghaoz
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template with minimal content filled in. The Description and Test Coverage sections are empty, and most checklist items are unchecked, leaving required context unexplained. Complete the Description section explaining why the test waiver is being removed. Add Test Coverage details and ensure checklist items are reviewed and marked as appropriate.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: removing a test waiver for a fixed test case, with the NVBugs reference included.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@mzweilz

mzweilz commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

/bot run --stage-list "GH200-TensorRT-Post-Merge-*"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52671 [ run ] triggered by Bot. Commit: ceaf4e0 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52671 [ run ] completed with state FAILURE. Commit: ceaf4e0
/LLM/main/L0_MergeRequest_PR pipeline #41943 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@longlee0622

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "GH200-TensorRT-Post-Merge-*"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52688 [ run ] triggered by Bot. Commit: ceaf4e0 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52688 [ run ] completed with state FAILURE. Commit: ceaf4e0
/LLM/main/L0_MergeRequest_PR pipeline #41955 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@mzweilz

mzweilz commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

/bot run --stage-list "GH200-TensorRT-Post-Merge-*"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52701 [ run ] triggered by Bot. Commit: ceaf4e0 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52701 [ run ] completed with state FAILURE. Commit: ceaf4e0
/LLM/main/L0_MergeRequest_PR pipeline #41967 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@mzweilz

mzweilz commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

/bot run --stage-list "GH200-TensorRT-Post-Merge-*"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52745 [ run ] triggered by Bot. Commit: ceaf4e0 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52745 [ run ] completed with state SUCCESS. Commit: ceaf4e0
/LLM/main/L0_MergeRequest_PR pipeline #42006 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@longlee0622

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "verified in related postMerge stage test"

@longlee0622
longlee0622 enabled auto-merge (squash) June 8, 2026 12:53
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52778 [ skip ] triggered by Bot. Commit: ceaf4e0 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52778 [ skip ] completed with state SUCCESS. Commit: ceaf4e0
Skipping testing for commit ceaf4e0

Link to invocation

@longlee0622
longlee0622 merged commit b14794c into NVIDIA:main Jun 8, 2026
13 of 15 checks passed
@longlee0622
longlee0622 deleted the unwaive-fixed-test branch June 16, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants