[None][test] Waive 1 failed cases for main in QA CI - #14783
Conversation
Bug(s): 6244727 Requested by: qa@nvidia.com Jenkins build: https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_FUNCTION_TEST/2205/ Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
|
/bot run --stage-list "" |
📝 WalkthroughWalkthroughAdded a skip waiver entry to the test waivers list for ChangesTest Waiver Management
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
126-126: Waiver entry is correctly scoped and traceable; add explicit unwaive follow-up target.This waiver line is correctly formatted and linked to NVBUG 6244727, so coverage for this PR’s scope (waiver-list update) is sufficient.
Follow-up outside this PR: restore coverage by removing this waiver and re-enablingaccuracy/test_llm_api_pytorch.py::TestNemotronNas::test_auto_dtype_tp8inaccuracy/test_llm_api_pytorch.pyonce NVBUG 6244727 is fixed.Based on learnings: In
tests/integration/test_lists/waives.txt, prefer the short nvbug URL formathttps://nvbugs/XXXXfor consistency.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` at line 126, The waiver entry in waives.txt for accuracy/test_llm_api_pytorch.py::TestNemotronNas::test_auto_dtype_tp8 references NVBUG 6244727 but lacks an explicit follow-up; update the waiver line to include a clear unwaive action target: note "UNWAIVE when NVBUG 6244727 is fixed — remove this waiver and re-enable accuracy/test_llm_api_pytorch.py::TestNemotronNas::test_auto_dtype_tp8", and ensure the NVBUG link uses the short format https://nvbugs/6244727 for consistency.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 126: The waiver entry in waives.txt for
accuracy/test_llm_api_pytorch.py::TestNemotronNas::test_auto_dtype_tp8
references NVBUG 6244727 but lacks an explicit follow-up; update the waiver line
to include a clear unwaive action target: note "UNWAIVE when NVBUG 6244727 is
fixed — remove this waiver and re-enable
accuracy/test_llm_api_pytorch.py::TestNemotronNas::test_auto_dtype_tp8", and
ensure the NVBUG link uses the short format https://nvbugs/6244727 for
consistency.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c1a5e68c-5a2a-4774-8415-0a341b2594a4
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
PR_Github #51505 [ run ] triggered by Bot. Commit: |
|
PR_Github #51505 [ run ] completed with state |
|
/bot reuse-pipeline |
|
PR_Github #51528 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #51528 [ reuse-pipeline ] completed with state |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by qa@nvidia.com)
Target branch:
mainJenkins build: https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_FUNCTION_TEST/2205/
Bug(s): 6244727
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit