Skip to content

[None][test] Waive 1 failed cases for main in QA CI - #14783

Merged
xinhe-nv merged 5 commits into
NVIDIA:mainfrom
tensorrt-cicd:trtllm-ci-report/waive-20260530-113841
Jun 2, 2026
Merged

[None][test] Waive 1 failed cases for main in QA CI#14783
xinhe-nv merged 5 commits into
NVIDIA:mainfrom
tensorrt-cicd:trtllm-ci-report/waive-20260530-113841

Conversation

@tensorrt-cicd

@tensorrt-cicd tensorrt-cicd commented May 30, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by qa@nvidia.com)
Target branch: main
Jenkins build: https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_FUNCTION_TEST/2205/
Bug(s): 6244727

Waive entries added

accuracy/test_llm_api_pytorch.py::TestNemotronNas::test_auto_dtype_tp8 SKIP (https://nvbugs/6244727)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Summary by CodeRabbit

  • Tests
    • Added a test waiver entry for a specific test case.

Bug(s): 6244727
Requested by: qa@nvidia.com
Jenkins build: https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_FUNCTION_TEST/2205/

Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
@xinhe-nv
xinhe-nv marked this pull request as ready for review June 2, 2026 05:10
@xinhe-nv
xinhe-nv enabled auto-merge (squash) June 2, 2026 05:10
@xinhe-nv

xinhe-nv commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

/bot run --stage-list ""

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Added a skip waiver entry to the test waivers list for TestNemotronNas::test_auto_dtype_tp8 associated with NVBUG 6244727.

Changes

Test Waiver Management

Layer / File(s) Summary
Skip waiver for auto_dtype_tp8 test
tests/integration/test_lists/waives.txt
Added a single-line skip waiver entry for accuracy/test_llm_api_pytorch.py::TestNemotronNas::test_auto_dtype_tp8 with NVBUG reference 6244727.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14163: Both PRs add new SKIP waivers to the same test waivers file for failing accuracy/test_llm_api_pytorch.py test cases.
  • NVIDIA/TensorRT-LLM#14062: Both PRs update tests/integration/test_lists/waives.txt by adding a new SKIP entry for a test in accuracy/test_llm_api_pytorch.py with an NVBUG reference.
  • NVIDIA/TensorRT-LLM#13147: Both PRs add a SKIP waiver entry in the same waivers file for accuracy/test_llm_api_pytorch.py::TestNemotronNas::test_auto_dtype_tp8.

Suggested reviewers

  • crazydemo
  • jieli-matrix
  • StanleySun639
  • LarryXFly
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete per the template requirements. It lacks required sections: description of the issue/solution, test coverage details, and PR checklist acknowledgment. However, it clearly states the PR purpose and waive entries. Add missing template sections including a 'Description' section explaining the test failure and reason for waiving, and complete the PR Checklist with appropriate checkmarks.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required template with [None][test] prefix and clearly describes the action (waiving 1 failed test case for main CI), which aligns with the actual changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)

126-126: Waiver entry is correctly scoped and traceable; add explicit unwaive follow-up target.

This waiver line is correctly formatted and linked to NVBUG 6244727, so coverage for this PR’s scope (waiver-list update) is sufficient.
Follow-up outside this PR: restore coverage by removing this waiver and re-enabling accuracy/test_llm_api_pytorch.py::TestNemotronNas::test_auto_dtype_tp8 in accuracy/test_llm_api_pytorch.py once NVBUG 6244727 is fixed.

Based on learnings: In tests/integration/test_lists/waives.txt, prefer the short nvbug URL format https://nvbugs/XXXX for consistency.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/integration/test_lists/waives.txt` at line 126, The waiver entry in
waives.txt for
accuracy/test_llm_api_pytorch.py::TestNemotronNas::test_auto_dtype_tp8
references NVBUG 6244727 but lacks an explicit follow-up; update the waiver line
to include a clear unwaive action target: note "UNWAIVE when NVBUG 6244727 is
fixed — remove this waiver and re-enable
accuracy/test_llm_api_pytorch.py::TestNemotronNas::test_auto_dtype_tp8", and
ensure the NVBUG link uses the short format https://nvbugs/6244727 for
consistency.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 126: The waiver entry in waives.txt for
accuracy/test_llm_api_pytorch.py::TestNemotronNas::test_auto_dtype_tp8
references NVBUG 6244727 but lacks an explicit follow-up; update the waiver line
to include a clear unwaive action target: note "UNWAIVE when NVBUG 6244727 is
fixed — remove this waiver and re-enable
accuracy/test_llm_api_pytorch.py::TestNemotronNas::test_auto_dtype_tp8", and
ensure the NVBUG link uses the short format https://nvbugs/6244727 for
consistency.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c1a5e68c-5a2a-4774-8415-0a341b2594a4

📥 Commits

Reviewing files that changed from the base of the PR and between 702e39d and cbd50ee.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator Author

PR_Github #51505 [ run ] triggered by Bot. Commit: cbd50ee Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator Author

PR_Github #51505 [ run ] completed with state SUCCESS. Commit: cbd50ee
/LLM/main/L0_MergeRequest_PR pipeline #40910 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@xinhe-nv

xinhe-nv commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

/bot reuse-pipeline

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator Author

PR_Github #51528 [ reuse-pipeline ] triggered by Bot. Commit: 4d68961 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator Author

PR_Github #51528 [ reuse-pipeline ] completed with state SUCCESS. Commit: 4d68961
Reusing PR_Github #51505 (Partly Tested) for commit 4d68961

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants