Skip to content

[https://nvbugs/6278380][unwaive] unwaive ad cases - #15148

Merged
crazydemo merged 1 commit into
NVIDIA:mainfrom
crazydemo:unwaive_cases
Jun 9, 2026
Merged

[https://nvbugs/6278380][unwaive] unwaive ad cases#15148
crazydemo merged 1 commit into
NVIDIA:mainfrom
crazydemo:unwaive_cases

Conversation

@crazydemo

@crazydemo crazydemo commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Updated integration test waiver configurations to adjust which accuracy validation tests are included in the test suite.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
@crazydemo
crazydemo enabled auto-merge (squash) June 9, 2026 07:56
@crazydemo

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 02f0ab2d-0d99-4957-bf54-95eb89f27700

📥 Commits

Reviewing files that changed from the base of the PR and between a90fd15 and c011fd9.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Updated tests/integration/test_lists/waives.txt to modify waived integration tests. The DeepSeek model waiver was removed from TestModelRegistryAccuracy::test_autodeploy_from_registry, and the Qwen model entries were adjusted by removing the test_nvfp4[8] variant while keeping test_bf16_small[4] with repositioned model registry entries.

Changes

Integration Test Waiver Adjustments

Layer / File(s) Summary
Autodeploy accuracy test waivers
tests/integration/test_lists/waives.txt
Removed waive for deepseek-ai_DeepSeek-R1-0528-True from TestModelRegistryAccuracy::test_autodeploy_from_registry, removed test_nvfp4[8] from TestQwen3_5_397B_MoE waivers, and adjusted placement of nvidia_Llama-3.1-8B-Instruct-NVFP4-True and test_bf16_small[4] entries within the skip list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#15056: Both PRs modify waivers for TestModelRegistryAccuracy::test_autodeploy_from_registry[deepseek-ai_DeepSeek-R1-0528-True] and TestQwen3_5_397B_MoE::test_nvfp4[8] in opposite directions.
  • NVIDIA/TensorRT-LLM#15086: Both PRs adjust Qwen-related autodeploy test waivers including nvfp4/bf16 variants in the same test list.
  • NVIDIA/TensorRT-LLM#14783: Both PRs modify tests/integration/test_lists/waives.txt to adjust SKIP waivers for accuracy/test_llm_api_autodeploy.py tests.

Suggested reviewers

  • xinhe-nv
  • jieli-matrix
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely empty, containing only the template structure with no substantive content filled in for the Description or Test Coverage sections. Add a clear description explaining why these test cases are being unwaived and describe the test coverage implications of these changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title includes a valid NVBugs ticket format and describes the main change (unwaiving test cases), which aligns with the file modifications in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@crazydemo

Copy link
Copy Markdown
Collaborator Author

/bot run --post-merge

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53006 [ run ] triggered by Bot. Commit: c011fd9 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53009 [ run ] triggered by Bot. Commit: c011fd9 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53006 [ run ] completed with state ABORTED. Commit: c011fd9

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53009 [ run ] completed with state SUCCESS. Commit: c011fd9
/LLM/main/L0_MergeRequest_PR pipeline #42236 completed with status: 'SUCCESS'

CI Report

Link to invocation

@crazydemo
crazydemo merged commit 2ee96cf into NVIDIA:main Jun 9, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants