[https://nvbugs/6278377][fix] Prepend a no-quant baseline entry (- accuracy: 88) under… - #15380
Closed
tensorrt-cicd wants to merge 1 commit into
Closed
[https://nvbugs/6278377][fix] Prepend a no-quant baseline entry (- accuracy: 88) under…#15380tensorrt-cicd wants to merge 1 commit into
- accuracy: 88) under…#15380tensorrt-cicd wants to merge 1 commit into
Conversation
….7-Flash GSM8K
The TestStep3_7::test_auto_dtype[tp_size=8-ep_size=8] case loads the
unquantized Step-3.7-Flash checkpoint (no quant_algo, no spec_dec_algo),
but references/gsm8k.yaml only contained quantized entries
(FP8_BLOCK_SCALES, NVFP4) for stepfun-ai/Step-3.7-Flash. The lookup in
AccuracyTask.get_hypothesis_testing_params raised
ValueError("Not registered specs: ...").
Add a no-quant baseline entry (accuracy: 88) so the auto-dtype lookup
matches. Verified on B300 8xGPU: measured 90.26, threshold 84.797.
Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single line is added to the GSM8K accuracy reference YAML file, inserting a new list entry with ChangesGSM8K Accuracy Reference Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
xinhe-nv
approved these changes
Jun 16, 2026
Member
|
included the changes in #15583, closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
references/gsm8k.yamlhad only quantized entries (FP8_BLOCK_SCALES, NVFP4) forstepfun-ai/Step-3.7-Flash, so the BF16/auto lookup fromtest_auto_dtypehad no match and raisedValueError("Not registered specs: ...").- accuracy: 88) understepfun-ai/Step-3.7-Flashingsm8k.yaml, matching the existing 88 baseline used for the FP8/NVFP4 variants.Test plan
Links
Summary by CodeRabbit