Skip to content

[https://nvbugs/6274932] [fix] Fix and unwaive step3p7 test cases - #15583

Merged
kaiyux merged 3 commits into
NVIDIA:mainfrom
kaiyux:user/kaiyu/unwaive_step3p7
Jun 25, 2026
Merged

[https://nvbugs/6274932] [fix] Fix and unwaive step3p7 test cases#15583
kaiyux merged 3 commits into
NVIDIA:mainfrom
kaiyux:user/kaiyu/unwaive_step3p7

Conversation

@kaiyux

@kaiyux kaiyux commented Jun 24, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes

    • Updated accuracy reference data for one model entry.
    • Adjusted test skipping and waiver coverage so the relevant model tests run under the intended hardware conditions.
  • Chores

    • Cleaned up obsolete test waiver entries for specific model configurations.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

For the stepfun-ai/Step-3.7-Flash model, @skip_pre_blackwell is moved from method-level to class-level in both TestStep3_7 test classes (pytorch and multimodal). Nine FP8 block-scale SKIP waive entries for A100, H100, and B200 are removed from waives.txt. A top-level accuracy: 88 field is added to the gsm8k.yaml reference entry.

Changes

Step-3.7-Flash skip promotion and waive cleanup

Layer / File(s) Summary
Promote @skip_pre_blackwell to class level for TestStep3_7
tests/integration/defs/accuracy/test_llm_api_pytorch.py, tests/integration/defs/accuracy/test_llm_api_pytorch_multimodal.py
@skip_pre_blackwell is added at the TestStep3_7 class level in both files and removed from the preceding method-level position near test_nvfp4, so the decorator governs the entire class rather than individual methods.
Remove Step3_7 FP8 block-scale waives and add accuracy reference
tests/integration/test_lists/waives.txt, tests/integration/defs/accuracy/references/gsm8k.yaml
Nine full:A100, full:B200, and full:H100 Step3_7 FP8 block-scale SKIP waive entries (including multimodal variants) are deleted from waives.txt. A standalone accuracy: 88 top-level field is added to the stepfun-ai/Step-3.7-Flash entry in gsm8k.yaml.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#15504: Modifies the same H100 waiver blocks in waives.txt for Step3_7 FP8 block-scale and multimodal FP8 block-scale entries at overlapping lines.
  • NVIDIA/TensorRT-LLM#15535: Changes TestStep3_7 FP8 block-scale waive entries in waives.txt with additions/remappings that directly overlap with this PR's removals.
  • NVIDIA/TensorRT-LLM#15581: Adjusts TestStep3_7-related SKIP/waive entries in waives.txt by adding new SKIP entries for test_fp8_block_scales/test_nvfp4, counterpart to this PR's removals.

Suggested reviewers

  • StanleySun639
  • jieli-matrix
  • crazydemo
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is mostly the template text and does not explain the issue, solution, or test coverage. Add a short Description section with the problem and fix, and a Test Coverage section listing the tests run or expected to guard the changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title includes the NVBugs ID and fix type and accurately reflects the Step3.7 test unwaive and skip changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@kaiyux kaiyux changed the title [https://nvbugspro.nvidia.com/bug/6274932] [fix] Fix and unwaive step3p7 test cases [https://nvbugs/6274932] [fix] Fix and unwaive step3p7 test cases Jun 24, 2026
@kaiyux

kaiyux commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55468 [ run ] triggered by Bot. Commit: 8675fd2 Link to invocation

@kaiyux
kaiyux enabled auto-merge (squash) June 24, 2026 09:09
kaiyux added 3 commits June 24, 2026 04:18
Move @skip_pre_blackwell to the TestStep3_7 class level in both
test_llm_api_pytorch.py and test_llm_api_pytorch_multimodal.py so the
fp8_block_scales cases skip on pre-Blackwell GPUs (A100/H100) instead of
failing, and drop the now-redundant A100/H100 waive entries for
nvbugs/6274932.

Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
…e=8-ep_size=8]

Remove the waive for the tp8/ep8 auto_dtype Step3.7 case and add the
default-dtype gsm8k accuracy reference entry it depends on.

Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
@kaiyux
kaiyux force-pushed the user/kaiyu/unwaive_step3p7 branch from 8675fd2 to e50bd64 Compare June 24, 2026 11:19
@kaiyux

kaiyux commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55488 [ run ] triggered by Bot. Commit: e50bd64 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55468 [ run ] completed with state ABORTED. Commit: 8675fd2

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55488 [ run ] completed with state FAILURE. Commit: e50bd64
/LLM/main/L0_MergeRequest_PR pipeline #44413 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@kaiyux

kaiyux commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55643 [ run ] triggered by Bot. Commit: e50bd64 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55643 [ run ] completed with state FAILURE. Commit: e50bd64
/LLM/main/L0_MergeRequest_PR pipeline #44554 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@kaiyux

kaiyux commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55751 [ run ] triggered by Bot. Commit: e50bd64 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55751 [ run ] completed with state SUCCESS. Commit: e50bd64
/LLM/main/L0_MergeRequest_PR pipeline #44650 completed with status: 'SUCCESS'

CI Report

Link to invocation

@kaiyux
kaiyux merged commit b37a5aa into NVIDIA:main Jun 25, 2026
7 checks passed
@kaiyux
kaiyux deleted the user/kaiyu/unwaive_step3p7 branch June 25, 2026 12:41
BrianLi23 pushed a commit to BrianLi23/TensorRT-LLM that referenced this pull request Jul 9, 2026
…IDIA#15583)

Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants