[https://nvbugs/6274932] [fix] Fix and unwaive step3p7 test cases - #15583
Conversation
d8eeda7 to
9e664e9
Compare
📝 WalkthroughWalkthroughFor the ChangesStep-3.7-Flash skip promotion and waive cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --disable-fail-fast |
|
PR_Github #55468 [ run ] triggered by Bot. Commit: |
Move @skip_pre_blackwell to the TestStep3_7 class level in both test_llm_api_pytorch.py and test_llm_api_pytorch_multimodal.py so the fp8_block_scales cases skip on pre-Blackwell GPUs (A100/H100) instead of failing, and drop the now-redundant A100/H100 waive entries for nvbugs/6274932. Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
…e=8-ep_size=8] Remove the waive for the tp8/ep8 auto_dtype Step3.7 case and add the default-dtype gsm8k accuracy reference entry it depends on. Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
8675fd2 to
e50bd64
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #55488 [ run ] triggered by Bot. Commit: |
|
PR_Github #55468 [ run ] completed with state |
|
PR_Github #55488 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #55643 [ run ] triggered by Bot. Commit: |
|
PR_Github #55643 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #55751 [ run ] triggered by Bot. Commit: |
|
PR_Github #55751 [ run ] completed with state |
…IDIA#15583) Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
Summary by CodeRabbit
Bug Fixes
Chores
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.