Skip to content

[None][test] Waive hang issues - #15609

Merged
xinhe-nv merged 6 commits into
NVIDIA:mainfrom
xinhe-nv:waive
Jun 25, 2026
Merged

[None][test] Waive hang issues#15609
xinhe-nv merged 6 commits into
NVIDIA:mainfrom
xinhe-nv:waive

Conversation

@xinhe-nv

@xinhe-nv xinhe-nv commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Added skip/waive coverage for additional integration test configurations.
    • Expanded waivers for several DeepSeekV3Lite and GPTOSS test variants, including different precision, GPU, and scheduling combinations.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cd26cf60-2b7e-4c38-8dde-0d7edde6497a

📥 Commits

Reviewing files that changed from the base of the PR and between 970df5b and 23bb87c.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Adds five waiver entries in tests/integration/test_lists/waives.txt for additional DeepSeekV3Lite bfloat16/nvfp4 cases and GPTOSS eagle3_2gpus H20 overlap-scheduler cases.

Changes

Integration test waive updates

Layer / File(s) Summary
DeepSeekV3Lite waivers
tests/integration/test_lists/waives.txt
Adds waivers for test_bfloat16_4gpus_online_eplb (mtp_nextn=0, moe_backend=WIDEEP) and test_nvfp4_4gpus_online_eplb (fp8kv=False/True, moe_backend=WIDEEP).
GPTOSS H20 waivers
tests/integration/test_lists/waives.txt
Adds full-matrix H20 waivers for TestGPTOSS::test_eagle3_2gpus with triton-one_model and triton-two_model overlap scheduling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#15509: Also updates tests/integration/test_lists/waives.txt with TestDeepSeekV3Lite waiver entries for test_bfloat16 and test_nvfp4 parameterizations.
  • NVIDIA/TensorRT-LLM#15511: Also changes the same waiver list with overlapping model/config combinations, including GPTOSS scheduling-related entries.
  • NVIDIA/TensorRT-LLM#15581: Also adds nvfp4-related SKIP/waive entries to tests/integration/test_lists/waives.txt.

Suggested reviewers

  • crazydemo
  • jieli-matrix
  • LarryXFly
  • StanleySun639
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is just the template with no issue context, solution details, or test coverage filled in. Replace the template text with a real Description and Test Coverage section that explains the problem, the waiver changes, and how they were validated.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and matches the main change of adding hang waivers for tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

xinhe-nv added 3 commits June 25, 2026 14:31
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
xinhe-nv added 2 commits June 25, 2026 14:33
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "waive test only"

@xinhe-nv
xinhe-nv enabled auto-merge (squash) June 25, 2026 07:21
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55739 [ skip ] triggered by Bot. Commit: c92efce Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55739 [ skip ] completed with state SUCCESS. Commit: c92efce
Skipping testing for commit c92efce

Link to invocation

@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "waive test only"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55747 [ skip ] triggered by Bot. Commit: 70c5b38 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55747 [ skip ] completed with state SUCCESS. Commit: 70c5b38
Skipping testing for commit 70c5b38

Link to invocation

@xinhe-nv
xinhe-nv merged commit 34242e4 into NVIDIA:main Jun 25, 2026
7 checks passed
@xinhe-nv
xinhe-nv deleted the waive branch June 25, 2026 08:36
BrianLi23 pushed a commit to BrianLi23/TensorRT-LLM that referenced this pull request Jul 9, 2026
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants