Skip to content

[None][test] waive hang issues - #15581

Merged
xinhe-nv merged 2 commits into
NVIDIA:mainfrom
xinhe-nv:waive
Jun 24, 2026
Merged

[None][test] waive hang issues#15581
xinhe-nv merged 2 commits into
NVIDIA:mainfrom
xinhe-nv:waive

Conversation

@xinhe-nv

@xinhe-nv xinhe-nv commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Updated the test waiver list to skip two additional accuracy checks under a specific configuration, helping keep automated test runs stable.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv
xinhe-nv requested a review from jieli-matrix June 24, 2026 08:19
@xinhe-nv
xinhe-nv requested a review from crazydemo June 24, 2026 08:19
@xinhe-nv
xinhe-nv enabled auto-merge (squash) June 24, 2026 08:19
@xinhe-nv xinhe-nv changed the title waive hang issues [None][test] waive hang issues Jun 24, 2026
@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Only waive tests"

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 38fbf389-74de-4c6b-86da-ff53ea48a440

📥 Commits

Reviewing files that changed from the base of the PR and between ca13cf3 and 312a491.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Two SKIP waiver entries are added to tests/integration/test_lists/waives.txt for accuracy/test_llm_api_pytorch.py::TestStep3_7, covering test_fp8_block_scales and test_nvfp4 with parameters tp_size=4-ep_size=4-mtp_nextn=3, both referencing https://nvbugs/6367805.

Changes

Test Waiver Additions

Layer / File(s) Summary
SKIP entries for fp8/nvfp4 with tp=4 ep=4 mtp=3
tests/integration/test_lists/waives.txt
Adds two SKIP waiver lines for TestStep3_7::test_fp8_block_scales and TestStep3_7::test_nvfp4 under tp_size=4-ep_size=4-mtp_nextn=3, both linked to nvbugs/6367805.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#15570: Adds SKIP waivers for the same accuracy/test_llm_api_pytorch.py::TestStep3_7 FP8 block scales cases with nvbugs-linked entries, directly overlapping with this PR's changes.
  • NVIDIA/TensorRT-LLM#15576: Adds/adjusts integration test waivers in the same file for the same TestStep3_7 test cases (test_fp8_block_scales and test_nvfp4) with matching TP/EP parameterizations.
  • NVIDIA/TensorRT-LLM#15535: Modifies the same waiver file to add SKIP entries for TestStep3_7 FP8 block-scale cases in test_llm_api_pytorch.py with NV bug ID references.

Suggested reviewers

  • crazydemo
  • jieli-matrix
  • StanleySun639
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is mostly the template text and lacks real issue, solution, and test coverage details. Add a brief Description and Test Coverage section that explains the waiver change, why it was needed, and how it was verified.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the change by describing test hang waivers, even though it is somewhat broad.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Only waive tests"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55457 [ skip ] triggered by Bot. Commit: 5247aef Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55459 [ skip ] triggered by Bot. Commit: 5247aef Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55457 [ skip ] completed with state ABORTED. Commit: 5247aef

Link to invocation

@xinhe-nv
xinhe-nv requested a review from StanleySun639 June 24, 2026 08:33
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55459 [ skip ] completed with state SUCCESS. Commit: 5247aef
Skipping testing for commit 5247aef

Link to invocation

@xinhe-nv
xinhe-nv merged commit 91c1e4a into NVIDIA:main Jun 24, 2026
7 checks passed
@xinhe-nv
xinhe-nv deleted the waive branch June 24, 2026 08:39
BrianLi23 pushed a commit to BrianLi23/TensorRT-LLM that referenced this pull request Jul 9, 2026
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants