Skip to content

[https://nvbugs/6384622][fix] increase free_mem_frac for failed perf test - #15879

Merged
reasonsolo merged 1 commit into
NVIDIA:mainfrom
reasonsolo:bug6384622
Jul 6, 2026
Merged

[https://nvbugs/6384622][fix] increase free_mem_frac for failed perf test#15879
reasonsolo merged 1 commit into
NVIDIA:mainfrom
reasonsolo:bug6384622

Conversation

@reasonsolo

@reasonsolo reasonsolo commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Updated a performance sanity configuration to reserve a bit more GPU memory for context caching, which may improve stability for the affected test scenario.
    • Removed an outdated test waiver entry, allowing the test to be evaluated normally again.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
@reasonsolo
reasonsolo marked this pull request as ready for review July 2, 2026 09:08
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR removes a SKIP waiver entry for a disaggregated NIXL performance sanity test case and increases the free_gpu_memory_fraction value in its associated context worker configuration from 0.3 to 0.4.

Changes

Test waiver and config update

Layer / File(s) Summary
Unwaive test and adjust KV cache config
tests/integration/test_lists/waives.txt, tests/scripts/perf-sanity/disaggregated/gb200_deepseek-r1-fp4_128k8k_con128_ctx1_pp8_gen1_dep16_eplb0_mtp1_ccb-NIXL.yaml
Removes the SKIP/nvbugs waiver for the disagg_upload NIXL test case and increases worker_config.ctx.kv_cache_config.free_gpu_memory_fraction from 0.3 to 0.4.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: mzweilz, chzblych, xinhe-nv

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is just the template and checklist, with no actual issue summary, solution, or test coverage filled in. Add a real Description and Test Coverage section that explains the change, why it was needed, and what tests validate it.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: increasing free GPU memory fraction for a perf-test fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@reasonsolo
reasonsolo enabled auto-merge (squash) July 2, 2026 09:15
@reasonsolo

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

1 similar comment
@reasonsolo

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57286 [ run ] triggered by Bot. Commit: 9564cd2 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57286 [ run ] completed with state FAILURE. Commit: 9564cd2
/LLM/main/L0_MergeRequest_PR pipeline #46047 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@reasonsolo

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57644 [ run ] triggered by Bot. Commit: 9564cd2 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57644 [ run ] completed with state SUCCESS. Commit: 9564cd2
/LLM/main/L0_MergeRequest_PR pipeline #46367 completed with status: 'SUCCESS'

CI Report

Link to invocation

@reasonsolo
reasonsolo requested a review from ZhanruiSunCh July 6, 2026 06:22
@reasonsolo
reasonsolo merged commit ceae332 into NVIDIA:main Jul 6, 2026
13 of 15 checks passed
BrianLi23 pushed a commit to BrianLi23/TensorRT-LLM that referenced this pull request Jul 9, 2026
…test (NVIDIA#15879)

Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants