Skip to content

[https://nvbugs/6266302][test] Unwaive test_disaggregated_llama_context_capacity - #15800

Merged
Tabrizian merged 1 commit into
NVIDIA:mainfrom
Tabrizian:unwaive-disagg-context-capacity-6266302
Jul 1, 2026
Merged

[https://nvbugs/6266302][test] Unwaive test_disaggregated_llama_context_capacity#15800
Tabrizian merged 1 commit into
NVIDIA:mainfrom
Tabrizian:unwaive-disagg-context-capacity-6266302

Conversation

@Tabrizian

@Tabrizian Tabrizian commented Jun 30, 2026

Copy link
Copy Markdown
Member

Description

Unwaives the post-merge disaggregated test that was previously skipped under https://nvbugs/6266302:

disaggregated/test_disaggregated_single_gpu.py::test_disaggregated_llama_context_capacity[False-False-DeepSeek-V3-Lite-fp8/fp8]

The underlying issue is not reproducible.

Test Coverage

  • disaggregated/test_disaggregated_single_gpu.py::test_disaggregated_llama_context_capacity[False-False-DeepSeek-V3-Lite-fp8/fp8]

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Summary by CodeRabbit

  • Chores
    • Removed one obsolete test waiver from the integration test list.
    • No user-facing behavior changes were included.

@Tabrizian

Copy link
Copy Markdown
Member Author

/bot run --disable-fail-fast

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This change removes a single waiver entry from the test waivers list file, specifically the SKIP entry for test_disaggregated_llama_context_capacity with the [False-False-DeepSeek-V3-Lite-fp8/fp8] parameterization, re-enabling that test case in the disaggregated test suite.

Changes

Test waiver list update

Layer / File(s) Summary
Remove waiver entry
tests/integration/test_lists/waives.txt
Removes the SKIP waiver line for test_disaggregated_llama_context_capacity with [False-False-DeepSeek-V3-Lite-fp8/fp8] parameterization.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • chzblych
  • niukuo
  • EmmaQiaoCh
  • yiqingy0
  • mzweilz
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific and matches the main change: unwaiving the disaggregated test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description follows the template, explains the change and rationale, and includes test coverage plus a completed checklist.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Tabrizian

Copy link
Copy Markdown
Member Author

/bot run --stage-list "DGX_H100-PyTorch-4"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #56725 [ run ] triggered by Bot. Commit: ba2e8e1 Link to invocation

…xt_capacity

Unwaive disaggregated/test_disaggregated_single_gpu.py::test_disaggregated_llama_context_capacity[False-False-DeepSeek-V3-Lite-fp8/fp8]
which was skipped under https://nvbugs/6266302.

Signed-off-by: Iman Tabrizian <10105175+tabrizian@users.noreply.github.com>
@Tabrizian
Tabrizian force-pushed the unwaive-disagg-context-capacity-6266302 branch from ba2e8e1 to 7e76e0f Compare June 30, 2026 21:09
@Tabrizian

Copy link
Copy Markdown
Member Author

/bot run --stage-list "DGX_H100-PyTorch-4"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #56726 [ run ] triggered by Bot. Commit: 7e76e0f Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #56728 [ run ] triggered by Bot. Commit: 7e76e0f Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #56725 [ run ] completed with state ABORTED. Commit: ba2e8e1

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #56726 [ run ] completed with state ABORTED. Commit: 7e76e0f

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #56728 [ run ] completed with state SUCCESS. Commit: 7e76e0f
/LLM/main/L0_MergeRequest_PR pipeline #45547 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@Tabrizian

Copy link
Copy Markdown
Member Author

/bot run --stage-list "DGX_H100-PyTorch-1, DGX_H100-PyTorch-2, DGX_H100-PyTorch-3, DGX_H100-PyTorch-4, DGX_H100-PyTorch-5, DGX_H100-PyTorch-6"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #56774 [ run ] triggered by Bot. Commit: 7e76e0f Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #56774 [ run ] completed with state FAILURE. Commit: 7e76e0f
/LLM/main/L0_MergeRequest_PR pipeline #45591 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@Tabrizian

Copy link
Copy Markdown
Member Author

/bot run --disable-fail-fast --stage-list "DGX_H100-PyTorch-1, DGX_H100-PyTorch-2, DGX_H100-PyTorch-3, DGX_H100-PyTorch-4, DGX_H100-PyTorch-5, DGX_H100-PyTorch-6"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #56822 [ run ] triggered by Bot. Commit: 7e76e0f Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #56822 [ run ] completed with state SUCCESS. Commit: 7e76e0f
/LLM/main/L0_MergeRequest_PR pipeline #45638 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@Tabrizian

Copy link
Copy Markdown
Member Author

/bot run --disable-fail-fast --stage-list "DGX_H100-PyTorch-1, DGX_H100-PyTorch-2, DGX_H100-PyTorch-3, DGX_H100-PyTorch-4, DGX_H100-PyTorch-5, DGX_H100-PyTorch-6"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #56968 [ run ] triggered by Bot. Commit: 7e76e0f Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #56968 [ run ] completed with state SUCCESS. Commit: 7e76e0f
/LLM/main/L0_MergeRequest_PR pipeline #45770 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@Tabrizian

Copy link
Copy Markdown
Member Author

/bot run --disable-fail-fast --stage-list "DGX_H100-PyTorch-1, DGX_H100-PyTorch-2, DGX_H100-PyTorch-3, DGX_H100-PyTorch-4, DGX_H100-PyTorch-5, DGX_H100-PyTorch-6"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57005 [ run ] triggered by Bot. Commit: 7e76e0f Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57005 [ run ] completed with state SUCCESS. Commit: 7e76e0f
/LLM/main/L0_MergeRequest_PR pipeline #45804 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@Tabrizian

Copy link
Copy Markdown
Member Author

/bot skip --comment "test stage has passed"

@Tabrizian
Tabrizian enabled auto-merge (squash) July 1, 2026 19:39
@Tabrizian
Tabrizian requested a review from brb-nv July 1, 2026 19:40

@brb-nv brb-nv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57014 [ skip ] triggered by Bot. Commit: 7e76e0f Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #57014 [ skip ] completed with state SUCCESS. Commit: 7e76e0f
Skipping testing for commit 7e76e0f

Link to invocation

@Tabrizian
Tabrizian merged commit 50ea42a into NVIDIA:main Jul 1, 2026
8 checks passed
evezhier pushed a commit to evezhier/TensorRT-LLM that referenced this pull request Jul 2, 2026
…xt_capacity (NVIDIA#15800)

Signed-off-by: Iman Tabrizian <10105175+tabrizian@users.noreply.github.com>
BrianLi23 pushed a commit to BrianLi23/TensorRT-LLM that referenced this pull request Jul 9, 2026
…xt_capacity (NVIDIA#15800)

Signed-off-by: Iman Tabrizian <10105175+tabrizian@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants