Skip to content

[https://nvbugs/6327143][chore] Unwaive test cases - #16367

Merged
marinayanov merged 1 commit into
NVIDIA:mainfrom
nv-auto-deploy:myanov/unwaive-autodeploy-fp8-registry
Jul 16, 2026
Merged

[https://nvbugs/6327143][chore] Unwaive test cases#16367
marinayanov merged 1 commit into
NVIDIA:mainfrom
nv-auto-deploy:myanov/unwaive-autodeploy-fp8-registry

Conversation

@marinayanov

@marinayanov marinayanov commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Removed outdated test waivers for model registry auto-deployment accuracy checks on NVIDIA Llama 3.1 8B Instruct FP8 configurations.
    • These checks will now run as part of the standard integration test suite.

Description

accuracy/test_llm_api_autodeploy.py::TestModelRegistryAccuracy::test_autodeploy_from_registry[nvidia_Llama-3.1-8B-Instruct-FP8-True] was waived on L40S (nvbugs/6327143, CUDA OOM during MMLU eval) and on H20 (nvbugs/6422351, GSM8K below threshold). Both failures no longer reproduce on current main, and both bugs are already closed.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • [v ] Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

…nd H20

The test
accuracy/test_llm_api_autodeploy.py::TestModelRegistryAccuracy::test_autodeploy_from_registry[nvidia_Llama-3.1-8B-Instruct-FP8-True]
was waived on L40S (nvbugs/6327143, CUDA OOM during MMLU eval) and on H20
(nvbugs/6422351, GSM8K below threshold). Both failures no longer reproduce
on current main: validated on the intended hardware (8x L40S and 8x H20)
both in isolation and under QA-style sequential sessions, passing MMLU and
GSM8K thresholds with margin. nvbugs/6422351 is already closed Can't Reproduce.

Signed-off-by: marinayanov <256585945+marinayanov@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Removes two integration-test waiver entries for the FP8 model-registry autodeploy case on H20 and L40S.

Changes

Autodeploy waiver updates

Layer / File(s) Summary
Remove H20 and L40S waivers
tests/integration/test_lists/waives.txt
Deletes the H20 and L40S test_autodeploy_from_registry waiver entries for the specified NVIDIA Llama FP8 configuration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: bowenfu, schetlur-nv

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the change and follows the required ticket/type pattern, though the summary is a bit generic.
Description check ✅ Passed The required sections are present and the change is explained, but the Test Coverage section is empty.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@marinayanov

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1"

@github-actions

Copy link
Copy Markdown

👎 Promotion blocked, new vulnerability found

Vulnerability report

Component Vulnerability Description Severity
pytorch CVE-2025-3000 A vulnerability classified as critical has been found in PyTorch 2.6.0. This affects the function torch.jit.script. The manipulation leads to memory corruption. It is possible to launch the attack on the local host. The exploit has been disclosed to the public and may be used. MEDIUM

@marinayanov

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59187 [ run ] triggered by Bot. Commit: 6238c3b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59187 [ run ] completed with state FAILURE. Commit: 6238c3b
/LLM/main/L0_MergeRequest_PR pipeline #47688 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@marinayanov

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59496 [ run ] triggered by Bot. Commit: 6238c3b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59496 [ run ] completed with state SUCCESS. Commit: 6238c3b
/LLM/main/L0_MergeRequest_PR pipeline #47955 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

CI Report

Link to invocation

@yiqingy0
yiqingy0 removed their request for review July 16, 2026 02:22

@BowenFu BowenFu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — unwaive-only, and CI is green, so the two re-enabled test_autodeploy_from_registry[...FP8-True] variants (H20 + L40S) pass. Safe to remove the SKIPs.

@marinayanov
marinayanov merged commit 51457cc into NVIDIA:main Jul 16, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants