[https://nvbugs/6327143][chore] Unwaive test cases - #16367
Conversation
…nd H20 The test accuracy/test_llm_api_autodeploy.py::TestModelRegistryAccuracy::test_autodeploy_from_registry[nvidia_Llama-3.1-8B-Instruct-FP8-True] was waived on L40S (nvbugs/6327143, CUDA OOM during MMLU eval) and on H20 (nvbugs/6422351, GSM8K below threshold). Both failures no longer reproduce on current main: validated on the intended hardware (8x L40S and 8x H20) both in isolation and under QA-style sequential sessions, passing MMLU and GSM8K thresholds with margin. nvbugs/6422351 is already closed Can't Reproduce. Signed-off-by: marinayanov <256585945+marinayanov@users.noreply.github.com>
📝 WalkthroughWalkthroughRemoves two integration-test waiver entries for the FP8 model-registry autodeploy case on H20 and L40S. ChangesAutodeploy waiver updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --extra-stage "DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1" |
👎 Promotion blocked, new vulnerability foundVulnerability report
|
|
/bot run --extra-stage "DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1" |
|
PR_Github #59187 [ run ] triggered by Bot. Commit: |
|
PR_Github #59187 [ run ] completed with state
|
|
/bot run --extra-stage "DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1" |
|
PR_Github #59496 [ run ] triggered by Bot. Commit: |
|
PR_Github #59496 [ run ] completed with state |
BowenFu
left a comment
There was a problem hiding this comment.
LGTM — unwaive-only, and CI is green, so the two re-enabled test_autodeploy_from_registry[...FP8-True] variants (H20 + L40S) pass. Safe to remove the SKIPs.
Summary by CodeRabbit
Description
accuracy/test_llm_api_autodeploy.py::TestModelRegistryAccuracy::test_autodeploy_from_registry[nvidia_Llama-3.1-8B-Instruct-FP8-True] was waived on L40S (nvbugs/6327143, CUDA OOM during MMLU eval) and on H20 (nvbugs/6422351, GSM8K below threshold). Both failures no longer reproduce on current main, and both bugs are already closed.
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
[v ] Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.