[https://nvbugs/6396422][fix] Disable kv-cache reuse for MiniMax-M2 - #16383
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe MiniMaxM2 accuracy test now disables KV-cache block reuse by default, and its fine-grained FP8 test waiver is removed. ChangesMiniMaxM2 accuracy configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: tcherckez-nvidia <127761168+tcherckez-nvidia@users.noreply.github.com>
b5a2a38 to
f43a022
Compare
|
/bot run --extra-stage "DGX_H100-4_GPUs-AutoDeploy-1" |
|
PR_Github #59249 [ run ] triggered by Bot. Commit: |
|
PR_Github #59249 [ run ] completed with state
|
|
/bot run --stage-list "DGX_H100-4_GPUs-AutoDeploy-1" |
|
PR_Github #59363 [ run ] triggered by Bot. Commit: |
|
PR_Github #59363 [ run ] completed with state |
|
run |
|
/bot run |
|
PR_Github #59390 [ run ] triggered by Bot. Commit: |
|
PR_Github #59390 [ run ] completed with state |
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.