[None][infra] Use main as waive target branch in push event - #16397
[None][infra] Use main as waive target branch in push event#16397weiminwang-nv wants to merge 2 commits into
Conversation
Signed-off-by: Weimin Wang <301118019+weiminwang-nv@users.noreply.github.com>
📝 WalkthroughWalkthroughChangesMerge request pipeline
Estimated code review effort: 2 (Simple) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
jenkins/L0_MergeRequest.groovy (1)
1-1: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winAdd the required NVIDIA copyright header.
This modified file has no visible NVIDIA copyright header. As per coding guidelines, “Add the NVIDIA copyright header to all new files and update the copyright year on modified files.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@jenkins/L0_MergeRequest.groovy` at line 1, Add the standard NVIDIA copyright header at the top of the modified Jenkins file, before the `@Library` declaration, and update its year to the current year while preserving the existing pipeline content.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@jenkins/L0_MergeRequest.groovy`:
- Around line 333-337: The targetBranch selection must only force "main" when
both env.gitlabTargetBranch and env.gitlabSourceBranch are set and equal. Update
the conditional around targetBranch in the shown pipeline block to require both
branch variables before applying the push-trigger override, while preserving the
existing fallback to globalVars[TARGET_BRANCH] otherwise.
---
Outside diff comments:
In `@jenkins/L0_MergeRequest.groovy`:
- Line 1: Add the standard NVIDIA copyright header at the top of the modified
Jenkins file, before the `@Library` declaration, and update its year to the
current year while preserving the existing pipeline content.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 31766bb5-6343-4826-aeef-1b3a849bd1bc
📒 Files selected for processing (1)
jenkins/L0_MergeRequest.groovy
Signed-off-by: Weimin Wang <301118019+weiminwang-nv@users.noreply.github.com>
|
/bot run |
|
PR_Github #59330 [ run ] triggered by Bot. Commit: |
|
PR_Github #59330 [ run ] completed with state
|
Summary by CodeRabbit
Description
We trigger the L0_PostMerge pipeline by gitlab push webhook event. When we want to trigger the L0_PostMerge from a internal branch in gitlab repo, the “Merge Test Waive List” stage will fail in this case. Because the stage needs to read the TOT waive list of target branch from Github, while there is no such target branch in Github.
In this PR, we change the target branch of “Merge Test Waive List” stage to main branch when it's trigger by a push event.
Test Coverage
Before:
Build link
The “Merge Test Waive List” stage failed on fetch TOT waive list from Github:
With this PR:
Build link
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.