Skip to content

[TRTLLMINF-216][infra] use main as default target branch in L0_MergeRequest_PR - #16480

Merged
weiminwang-nv merged 1 commit into
NVIDIA:mainfrom
weiminwang-nv:infra/refine-default-target-branch
Jul 20, 2026
Merged

[TRTLLMINF-216][infra] use main as default target branch in L0_MergeRequest_PR#16480
weiminwang-nv merged 1 commit into
NVIDIA:mainfrom
weiminwang-nv:infra/refine-default-target-branch

Conversation

@weiminwang-nv

@weiminwang-nv weiminwang-nv commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Merge request processing now defaults the target branch to main when no target branch is provided.
    • Downstream automation receives a consistent target branch value instead of an empty value.

Description

When L0_PostMerge is triggered without any parameters, such as manually run from the Jenkins web page or by a Jenkins cron trigger, the pipeline should use reasonable default parameters and run normally. However, the current default value of target_branch in the gitlabTriggerPhrase parameters is null. As a result, when the pipeline is triggered without no parameters, the target_branch used by the Merge Test Waive List stage is set to null, causing this stage to fail.

This PR changes the default value of target_branch in the gitlabTriggerPhrase parameters to main, so that L0_PostMerge can run normally when triggered without parameters.

Test Coverage

Before:

The “Merge Test Waive List” stage failed on fetch TOT waive list from Github:

image

With this PR:

image

We manually trigger a post-merge (via run with parameter menu in jenkins web console ) without multi-gpu tests, the result is same as the gitlab-push-webhook-triggered version

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Weimin Wang <301118019+weiminwang-nv@users.noreply.github.com>
@weiminwang-nv

Copy link
Copy Markdown
Contributor Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59648 [ run ] triggered by Bot. Commit: fefd881 Link to invocation

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The merge request Jenkins pipeline now assigns main to globalVars[TARGET_BRANCH] when the bot-provided target branch is missing.

Changes

Merge request target branch

Layer / File(s) Summary
Default TARGET_BRANCH initialization
jenkins/L0_MergeRequest.groovy
The target branch fallback changes from null to main when gitlabParamsFromBot['target_branch'] is absent.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: zhanruisunch

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the main change and includes a valid ticket and type.
Description check ✅ Passed The description covers the issue, solution, test coverage, and checklist.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@jenkins/L0_MergeRequest.groovy`:
- Line 189: Update the TARGET_BRANCH assignment to use a null- and blank-safe
fallback to "main", ensuring absent, null, and empty target_branch values do not
propagate into globalVars or mergeWaiveList. Add coverage for all three input
cases while preserving the provided branch value when non-blank.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e7b2e4f1-c896-4ab0-9913-ae29cef724cb

📥 Commits

Reviewing files that changed from the base of the PR and between 44f0521 and fefd881.

📒 Files selected for processing (1)
  • jenkins/L0_MergeRequest.groovy

Comment thread jenkins/L0_MergeRequest.groovy
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59648 [ run ] completed with state SUCCESS. Commit: fefd881
/LLM/main/L0_MergeRequest_PR pipeline #48083 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@ZhanruiSunCh ZhanruiSunCh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiminwang-nv

Copy link
Copy Markdown
Contributor Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59922 [ run ] triggered by Bot. Commit: fefd881 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59922 [ run ] completed with state SUCCESS. Commit: fefd881
/LLM/main/L0_MergeRequest_PR pipeline #48324 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@weiminwang-nv

Copy link
Copy Markdown
Contributor Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59938 [ run ] triggered by Bot. Commit: fefd881 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59938 [ run ] completed with state FAILURE. Commit: fefd881
/LLM/main/L0_MergeRequest_PR pipeline #48339 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@weiminwang-nv
weiminwang-nv force-pushed the infra/refine-default-target-branch branch from 6245913 to fefd881 Compare July 20, 2026 06:54
@weiminwang-nv

Copy link
Copy Markdown
Contributor Author

/bot skip --comment "The CI does not cover these changes and they were manually tested and verified. "

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60300 [ skip ] triggered by Bot. Commit: fefd881 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60300 [ skip ] completed with state SUCCESS. Commit: fefd881
Skipping testing for commit fefd881

Link to invocation

@weiminwang-nv
weiminwang-nv merged commit 454fed3 into NVIDIA:main Jul 20, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants