[TRTLLMINF-216][infra] use main as default target branch in L0_MergeRequest_PR - #16480
Conversation
Signed-off-by: Weimin Wang <301118019+weiminwang-nv@users.noreply.github.com>
|
/bot run |
|
PR_Github #59648 [ run ] triggered by Bot. Commit: |
📝 WalkthroughWalkthroughThe merge request Jenkins pipeline now assigns ChangesMerge request target branch
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@jenkins/L0_MergeRequest.groovy`:
- Line 189: Update the TARGET_BRANCH assignment to use a null- and blank-safe
fallback to "main", ensuring absent, null, and empty target_branch values do not
propagate into globalVars or mergeWaiveList. Add coverage for all three input
cases while preserving the provided branch value when non-blank.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e7b2e4f1-c896-4ab0-9913-ae29cef724cb
📒 Files selected for processing (1)
jenkins/L0_MergeRequest.groovy
|
PR_Github #59648 [ run ] completed with state
|
|
/bot run |
|
PR_Github #59922 [ run ] triggered by Bot. Commit: |
|
PR_Github #59922 [ run ] completed with state
|
|
/bot run |
|
PR_Github #59938 [ run ] triggered by Bot. Commit: |
|
PR_Github #59938 [ run ] completed with state
|
6245913 to
fefd881
Compare
|
/bot skip --comment "The CI does not cover these changes and they were manually tested and verified. " |
|
PR_Github #60300 [ skip ] triggered by Bot. Commit: |
|
PR_Github #60300 [ skip ] completed with state |
Summary by CodeRabbit
mainwhen no target branch is provided.Description
When L0_PostMerge is triggered without any parameters, such as manually run from the Jenkins web page or by a Jenkins cron trigger, the pipeline should use reasonable default parameters and run normally. However, the current default value of target_branch in the gitlabTriggerPhrase parameters is null. As a result, when the pipeline is triggered without no parameters, the target_branch used by the Merge Test Waive List stage is set to null, causing this stage to fail.
This PR changes the default value of target_branch in the gitlabTriggerPhrase parameters to main, so that L0_PostMerge can run normally when triggered without parameters.
Test Coverage
Before:
The “Merge Test Waive List” stage failed on fetch TOT waive list from Github:
With this PR:
We manually trigger a post-merge (via
run with parametermenu in jenkins web console ) without multi-gpu tests, the result is same as the gitlab-push-webhook-triggered versionPR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.