[https://nvbugs/6272598][fix] Replace the positive isinstance(..., MpiPoolSession) check with a negative…#16411
Closed
trtllm-agent wants to merge 1 commit into
Closed
Conversation
…patch The session-reuse test infrastructure (tests/test_common/session_reuse.py) monkey-patches MpiPoolSession in tensorrt_llm.executor.proxy with a factory function to enable pool reuse across LLM instances. This broke isinstance(self.mpi_session, MpiPoolSession) in _start_executor_workers with TypeError: isinstance() arg 2 must be a type, a tuple of types, or a union. Switch to a negative check against the never-patched MpiCommSession / RemoteMpiCommSessionClient types, matching the pattern already used earlier in the same function. Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe worker initialization logic changes its MPI session type guard so ChangesMPI startup registration
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Jul 15, 2026
Collaborator
|
This fix is already merged by PR #16444 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isinstance(self.mpi_session, MpiPoolSession)raises TypeError because tests/test_common/session_reuse.py monkey-patches MpiPoolSession in tensorrt_llm.executor.proxy to a factory function (not a class).isinstance(..., MpiPoolSession)check with a negative check against(MpiCommSession, RemoteMpiCommSessionClient), mirroring the existing pattern in the same function.Test plan
Links
Summary by CodeRabbit