[https://nvbugs/6464991][fix] Drop the isinstance check and gate the register() call only on len(status)==3…#16489
Closed
trtllm-agent wants to merge 1 commit into
Closed
Conversation
… proxy The isinstance(self.mpi_session, MpiPoolSession) check in _start_executor_workers is fragile: session-reuse test infrastructure (tests/test_common/session_reuse.py) monkey-patches the module-level tensorrt_llm.executor.proxy.MpiPoolSession symbol with a plain function, which makes isinstance() raise "TypeError: isinstance() arg 2 must be a type". It also fails to recognize the _ReusableSession wrapper handed out by the reuse cache. The check gates WorkerProcessMonitor.register(), which already self-filters non-local identities by hostname/pid_namespace, so it is safe to invoke for any session type. Rely on len(status) == 3 alone as the authoritative signal that the worker sent identities. Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe worker initialization logic now registers ChangesWorker identity registration
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Jul 16, 2026
[https://nvbugs/6463831][fix] Replace
isinstance(self.mpi_session, MpiPoolSession) with `not…
#16491
Closed
Collaborator
|
close for it's just fixed in main #16444 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Links
Summary by CodeRabbit