[https://nvbugs/6410093][fix] updated cosmos3 lpips baseline#16436
[https://nvbugs/6410093][fix] updated cosmos3 lpips baseline#16436NVShreyas wants to merge 4 commits into
Conversation
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot run --post-merge --disable-multi-gpu-test |
|
PR_Github #59468 [ run ] triggered by Bot. Commit: |
|
PR_Github #59468 [ run ] completed with state
|
|
/bot run --post-merge --disable-multi-gpu-test |
|
/bot kill |
📝 WalkthroughWalkthroughRemoves two skip entries so Cosmos3 visual generation LPIPS comparisons for ChangesVisual generation validation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #59501 [ run ] triggered by Bot. Commit: |
|
PR_Github #59502 [ kill ] triggered by Bot. Commit: |
|
PR_Github #59501 [ run ] completed with state |
|
PR_Github #59502 [ kill ] completed with state |
|
/bot kill |
|
/bot run --post-merge --disable-multi-gpu-test |
|
PR_Github #59732 [ run ] triggered by Bot. Commit: |
|
PR_Github #59732 [ run ] completed with state
|
|
Thanks for the fix — the approach (refresh the LPIPS golden baseline + drop the waivers to re-enable the cases) is the right way to handle LPIPS drift. Two small asks before this is merged:
Happy to approve once these are addressed. |
fredricz-20070104
left a comment
There was a problem hiding this comment.
Please address the above comments before merging.
Thanks for your comments @fredricz-20070104. I have addressed both in the PR description. |
|
/bot run --post-merge --disable-multi-gpu-test --disable-fail-fast |
|
PR_Github #60005 [ run ] triggered by Bot. Commit: |
|
PR_Github #60005 [ run ] completed with state
|
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
0e0d951 to
a7d7804
Compare
|
/bot run --post-merge --disable-multi-gpu-test --disable-fail-fast |
|
PR_Github #60506 [ run ] triggered by Bot. Commit: |
|
PR_Github #60506 Bot args parsing error: Post-merge CI requested by --post-merge or a broad stage selector ('*' or 'Post-Merge') requires the |
|
Removed the "ci: post-merge approved" label because @NVShreyas could not be verified as an active member of NVIDIA/trt-llm-ci-approvers. Ask a member of that team to apply it. |
Signed-off-by: NVShreyas <158103197+NVShreyas@users.noreply.github.com>
Co-authored-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com> Signed-off-by: NVShreyas <158103197+NVShreyas@users.noreply.github.com>
|
/bot run --post-merge --disable-multi-gpu-test --disable-fail-fast |
|
PR_Github #61195 [ run ] triggered by Bot. Commit: |
|
PR_Github #61195 Bot args parsing error: Post-merge CI requested by --post-merge or a broad stage selector ('*' or 'Post-Merge') requires the |
This PR upgrades LPIPS baseline for cosmos3, fixing nvbugs - 6410093, 6418815, 6437341.
In a previous PR, cosmos3 transformer was updated to not pad inputs when running on 1 GPU, instead running attention forward for each of the 2 CFG batches. This fixed a bug causing accuracy degradation.
The current outputs were generated by running the LPIPS script manually and updating the golden references. The outputs have been visually validated and should be correct going forward.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.