Skip to content

[https://nvbugs/6403909][test] Remove attention backend test waiver#16400

Merged
yuxianq merged 1 commit into
NVIDIA:mainfrom
yuxianq:fix/test-attention-backend-nan
Jul 15, 2026
Merged

[https://nvbugs/6403909][test] Remove attention backend test waiver#16400
yuxianq merged 1 commit into
NVIDIA:mainfrom
yuxianq:fix/test-attention-backend-nan

Conversation

@yuxianq

@yuxianq yuxianq commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Removed an obsolete test waiver for an attention backend test, allowing it to run as part of the integration test suite.

Description

Remove the H100 waiver for the Qwen2 BF16 context-attention case tracked by NVBug 6403909.

The failure was reproduced on the bug-era build and isolated to the obsolete unconditional SM90 paged-context FMHA override. That override was removed by #15838, and the complete current attention test directory passes on H100, so the test should run normally in CI again.

Test Coverage

  • Exact bug-era test repeated 100 times: 100 passed.
  • Complete bug-era test_attention_backend matrix repeated 100 times: 93,200 passed.
  • Complete current H100 attention directory: 1,381 passed and 2,788 skipped.
  • Waiver parser: 474 entries parsed; all markers are SKIP.
  • python3 scripts/check_test_list.py --validate: 2,210 unique test entries validated.
  • Pre-commit waiver duplicate and AST validation hooks passed.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@yuxianq

yuxianq commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5171395e-74a0-48b1-852a-7f58200b1f9d

📥 Commits

Reviewing files that changed from the base of the PR and between 71d8291 and 711effd.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Removes one integration test waiver for the DGX_H100 attention backend test previously skipped under nvbugs/6403909.

Changes

Test waiver update

Layer / File(s) Summary
Remove attention backend waiver
tests/integration/test_lists/waives.txt
Deletes the waiver entry for the DGX_H100 attention backend test.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: schetlur-nv, brnguyen2

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects removing the NVBug 6403909 attention-backend waiver.
Description check ✅ Passed The description includes the required Description, Test Coverage, and PR Checklist sections and clearly explains the change and validation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59349 [ run ] triggered by Bot. Commit: 711effd Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59349 [ run ] completed with state SUCCESS. Commit: 711effd
/LLM/main/L0_MergeRequest_PR pipeline #47827 completed with status: 'SUCCESS'

CI Report

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants