[https://nvbugs/6403909][test] Remove attention backend test waiver#16400
Conversation
|
/bot run --disable-fail-fast |
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoves one integration test waiver for the DGX_H100 attention backend test previously skipped under nvbugs/6403909. ChangesTest waiver update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #59349 [ run ] triggered by Bot. Commit: |
|
PR_Github #59349 [ run ] completed with state |
Summary by CodeRabbit
Description
Remove the H100 waiver for the Qwen2 BF16 context-attention case tracked by NVBug 6403909.
The failure was reproduced on the bug-era build and isolated to the obsolete unconditional SM90 paged-context FMHA override. That override was removed by #15838, and the complete current attention test directory passes on H100, so the test should run normally in CI again.
Test Coverage
test_attention_backendmatrix repeated 100 times: 93,200 passed.SKIP.python3 scripts/check_test_list.py --validate: 2,210 unique test entries validated.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.