Skip to content

[https://nvbugs/6422339][fix] unwaive disagg tests - #16474

Merged
bo-nv merged 1 commit into
NVIDIA:mainfrom
bo-nv:main-6422339
Jul 17, 2026
Merged

[https://nvbugs/6422339][fix] unwaive disagg tests#16474
bo-nv merged 1 commit into
NVIDIA:mainfrom
bo-nv:main-6422339

Conversation

@bo-nv

@bo-nv bo-nv commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Updated performance test waiver coverage for generation-only scenarios.
    • Removed outdated waivers and retained or added entries for currently recognized test configurations, improving the accuracy of automated test reporting.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Bo Deng <deemod@nvidia.com>
@bo-nv

bo-nv commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast --stage-list "*GB200*PerfSanity*,*GB300*PerfSanity*"

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Updates the integration performance-test waiver list by removing obsolete disagg_upload-gen_only entries and adding or retaining current model and hardware combinations.

Changes

Performance test waiver updates

Layer / File(s) Summary
Refresh generation-only waiver entries
tests/integration/test_lists/waives.txt
Replaces selected DeepSeek-R1, GB300, Qwen3-235B, and DeepSeek-V32 waivers while retaining or adding specified DeepSeek-V32, kimi-k25-thinking, qwen3-235b, gpt-oss-120b, and GB300 glm-5 entries.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: brnguyen2, schetlur-nv

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The required template is present, but the Description and Test Coverage sections are empty placeholders. Fill in the Description with the issue and fix, and add concrete Test Coverage details instead of leaving template comments.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is specific, matches the NVBugs fix, and summarizes the main change to unwaive disagg tests.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59631 [ run ] triggered by Bot. Commit: b89b571 Link to invocation

@mzweilz mzweilz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify that all unwaived tests pass before merge.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59631 [ run ] completed with state FAILURE. Commit: b89b571
/LLM/main/L0_MergeRequest_PR pipeline #48068 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@bo-nv

bo-nv commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator Author

@bo-nv
bo-nv enabled auto-merge (squash) July 17, 2026 02:08
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59830 [ skip ] triggered by Bot. Commit: b89b571 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59830 [ skip ] completed with state SUCCESS. Commit: b89b571
Skipping testing for commit b89b571

Link to invocation

@bo-nv
bo-nv merged commit 09e0d3f into NVIDIA:main Jul 17, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants