[None][infra] Waive 14 failed cases for main in post-merge 2839 - #16465
Merged
mzweilz merged 1 commit intoJul 16, 2026
Merged
Conversation
Bug(s): 6463812, 6463814, 6463819, 6463822, 6463829 Requested by: @mzweilz Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
trtllm-agent
requested review from
BowenFu,
mzweilz,
niukuo,
schetlur-nv and
yufeiwu-nv
July 16, 2026 02:54
mzweilz
approved these changes
Jul 16, 2026
Collaborator
|
/bot skip --comment "waive only" |
mzweilz
enabled auto-merge (squash)
July 16, 2026 02:55
Contributor
📝 WalkthroughWalkthroughUpdates ChangesTest waiver updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
198-198: 📐 Maintainability & Code Quality | 🔵 TrivialTrack removal of these SKIPs as follow-up work.
These entries intentionally reduce executed coverage for visual generation, LLM API, performance sanity, and beam-search tests. Ensure bugs 6463822, 6463812, 6463829, 6463814, and 6463819 include criteria for removing the corresponding waivers once fixed.
Also applies to: 383-385, 409-418, 429-433, 462-462
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` at line 198, Update the waiver entries in waives.txt for bugs 6463822, 6463812, 6463829, 6463814, and 6463819 to include explicit follow-up removal criteria, identifying the corresponding SKIP tests and the conditions that must be met before each waiver is removed.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 198: Separate the unrelated waiver cohorts in
tests/integration/test_lists/waives.txt: keep the visual-generation, LLM API,
and sampler waivers distinct from the performance-refresh entries, including the
referenced ranges. Preserve each waiver entry and only reorganize or split the
changes so this pull request addresses a single concern, unless the repository
provides a documented reason to keep them together.
---
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 198: Update the waiver entries in waives.txt for bugs 6463822, 6463812,
6463829, 6463814, and 6463819 to include explicit follow-up removal criteria,
identifying the corresponding SKIP tests and the conditions that must be met
before each waiver is removed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: ba4e5de9-c17f-4c7e-ad72-ae9aab26e4e9
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
Collaborator
|
PR_Github #59594 [ skip ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #59594 [ skip ] completed with state |
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @mzweilz)
Target branch:
mainBug(s): 6463812, 6463814, 6463819, 6463822, 6463829
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit