Skip to content

[https://nvbugs/6475622][chore] Unwaive tests - #16638

Merged
2ez4bz merged 1 commit into
NVIDIA:mainfrom
2ez4bz:dev-bug-6475622
Jul 21, 2026
Merged

[https://nvbugs/6475622][chore] Unwaive tests#16638
2ez4bz merged 1 commit into
NVIDIA:mainfrom
2ez4bz:dev-bug-6475622

Conversation

@2ez4bz

@2ez4bz 2ez4bz commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Description

QA needs to update their install scripts to include opencv.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Summary by CodeRabbit

  • Tests
    • Re-enabled several integration tests for automatic data types and disaggregated multimodal video processing across supported hardware configurations.
    • Removed outdated test exemptions so these scenarios are now included in regular test coverage.

QA needs to update their install scripts to include opencv.

Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
@2ez4bz
2ez4bz marked this pull request as ready for review July 20, 2026 21:13
@2ez4bz
2ez4bz requested review from a team as code owners July 20, 2026 21:13
@2ez4bz

2ez4bz commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Removes ten waived integration-test entries for NanoV3Omni auto-dtype and VideoMME disaggregation configurations across B200, B300, GB200, GB300, and H20 targets.

Changes

Multimodal waiver removal

Layer / File(s) Summary
Remove waived test configurations
tests/integration/test_lists/waives.txt
Deletes obsolete TestNanoV3Omni and TestVideoMMEEPD waiver entries for the affected hardware targets and parameterizations.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: dongxuy04

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the changeset and uses the required ticket/type format clearly.
Description check ✅ Passed The description states the issue and solution, and the remaining template is mostly filled out.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60461 [ run ] triggered by Bot. Commit: a38cfbc Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60461 [ run ] completed with state FAILURE. Commit: a38cfbc
/LLM/main/L0_MergeRequest_PR pipeline #48794 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@yuanjingx87

Copy link
Copy Markdown
Collaborator

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60476 [ run ] triggered by Bot. Commit: a38cfbc Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60476 [ run ] completed with state FAILURE. Commit: a38cfbc
/LLM/main/L0_MergeRequest_PR pipeline #48807 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@2ez4bz

2ez4bz commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60482 [ run ] triggered by Bot. Commit: a38cfbc Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60482 [ run ] completed with state SUCCESS. Commit: a38cfbc
/LLM/main/L0_MergeRequest_PR pipeline #48813 completed with status: 'SUCCESS'

CI Report

Link to invocation

@2ez4bz
2ez4bz enabled auto-merge (squash) July 21, 2026 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants