[https://nvbugs/6463814][chore] Unwaive passing perf-sanity disagg tests - #16655
Conversation
Bug 6463814 waived 7 GB200 disagg perf-sanity cases after L0_PostMerge NVIDIA#2839. Re-triage found the only real failure was aggr_upload-qwen3_5_397b_fp4_blackwell-qwen3_5_397b_fp4_tep8_1k1k (GDN decode tensor-alignment error), now tracked separately in sub-bug 6477124. The 7 disagg_upload GB200 NIXL cases waived under 6463814 are passing again, so unwaive them: - disagg_upload-e2e-gb200_deepseek-r1-fp4_8k1k_con4096_ctx1_dep4_gen1_dep16_eplb0_mtp1_ccb-NIXL - disagg_upload-e2e-gb200_deepseek-v32-fp4_32k4k_con2048_ctx1_dep4_gen1_dep32_eplb288_mtp1_ccb-NIXL - disagg_upload-e2e-gb200_deepseek-v32-fp4_8k1k_con4096_ctx1_dep4_gen1_dep32_eplb256_mtp0_ccb-NIXL - disagg_upload-e2e-gb200_kimi-k25-thinking-fp4_8k1k_con4096_ctx1_dep4_gen1_dep16_eplb0_mtp0_ccb-NIXL - disagg_upload-gen_only-gb200_deepseek-r1-fp4_128k8k_con128_ctx1_pp8_gen1_dep16_eplb0_mtp1_ccb-NIXL - disagg_upload-gen_only-gb200_deepseek-v32-fp4_8k1k_con1024_ctx1_dep4_gen1_dep32_eplb256_mtp3_ccb-NIXL - disagg_upload-gen_only-gb200_kimi-k25-thinking-fp4_8k1k_con4096_ctx1_dep4_gen1_dep16_eplb0_mtp0_ccb-NIXL Signed-off-by: Chenfei Zhang <chenfeiz@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughUpdated integration test waivers by removing obsolete disaggregated upload entries and adding four configuration-specific waivers with updated nvbugs references. ChangesIntegration waiver updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot skip --comment "Only unwaive perf tests, no need to run the whole CI pipeline" |
|
PR_Github #60564 [ skip ] triggered by Bot. Commit: |
|
PR_Github #60564 [ skip ] completed with state |
Summary by CodeRabbit
Description
Bug 6463814 waived 7 GB200 disaggregated perf-sanity cases after
LLM/main/L0_PostMerge #2839. Re-triage found the only real failure wasaggr_upload-qwen3_5_397b_fp4_blackwell-qwen3_5_397b_fp4_tep8_1k1k(GDN decode "Tensor data pointer is not aligned to 32 bytes" error), which is now tracked separately in sub-bug 6477124 and is not part of this bug's waiver set.The 7
disagg_uploadGB200 NIXL cases waived under 6463814 were auto-flagged flaky ("Test terminated unexpectedly") and are passing again, so this PR unwaives them:disagg_upload-e2e-gb200_deepseek-r1-fp4_8k1k_con4096_ctx1_dep4_gen1_dep16_eplb0_mtp1_ccb-NIXLdisagg_upload-e2e-gb200_deepseek-v32-fp4_32k4k_con2048_ctx1_dep4_gen1_dep32_eplb288_mtp1_ccb-NIXLdisagg_upload-e2e-gb200_deepseek-v32-fp4_8k1k_con4096_ctx1_dep4_gen1_dep32_eplb256_mtp0_ccb-NIXLdisagg_upload-e2e-gb200_kimi-k25-thinking-fp4_8k1k_con4096_ctx1_dep4_gen1_dep16_eplb0_mtp0_ccb-NIXLdisagg_upload-gen_only-gb200_deepseek-r1-fp4_128k8k_con128_ctx1_pp8_gen1_dep16_eplb0_mtp1_ccb-NIXLdisagg_upload-gen_only-gb200_deepseek-v32-fp4_8k1k_con1024_ctx1_dep4_gen1_dep32_eplb256_mtp3_ccb-NIXLdisagg_upload-gen_only-gb200_kimi-k25-thinking-fp4_8k1k_con4096_ctx1_dep4_gen1_dep16_eplb0_mtp0_ccb-NIXLTest Coverage
Removing a waiver must not skip the post-merge stages that cover these cases. The unwaived cases live on these GB200 disagg perf-sanity post-merge stages (from #2839):
Maintainer: please trigger the corresponding post-merge stages when running CI, e.g.:
PR Checklist
This is a waiver-list-only change (
tests/integration/test_lists/waives.txt); no source or API changes.