[https://nvbugs/6484343][fix] Renamed MTPEagleDynamicTreeWorker.forward → _forward_impl; the base…#16729
Open
chenfeiz0326 wants to merge 1 commit into
Open
[https://nvbugs/6484343][fix] Renamed MTPEagleDynamicTreeWorker.forward → _forward_impl; the base…#16729chenfeiz0326 wants to merge 1 commit into
MTPEagleDynamicTreeWorker.forward → _forward_impl; the base…#16729chenfeiz0326 wants to merge 1 commit into
Conversation
…rward_impl Signed-off-by: Chenfei Zhang <chenfeiz@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe MTP dynamic tree worker method is renamed from ChangesMTP dynamic tree entry method
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forwardmethod, which SpecWorkerBase.init_subclass (guard from nvbugs/6442074) forbids, raising TypeError at import and collecting 0 tests.MTPEagleDynamicTreeWorker.forward→_forward_impl; the base wrapper now drives it. No internal callers of self.forward exist, so the rename is safe.Test plan
Links
Dev Engineer Review
MTPEagleDynamicTreeWorker.forwardto_forward_implto satisfy theSpecWorkerBase.__init_subclass__guard.mtp_dyn.forward), avoiding behavioral or performance changes.self.forwardcallers.QA Engineer Review
No test changes.