[https://nvbugs/6478697][fix] Renamed mtp_dynamic_tree.py:639 forward → _forward_impl (matching…#16727
Closed
chenfeiz0326 wants to merge 1 commit into
Closed
[https://nvbugs/6478697][fix] Renamed mtp_dynamic_tree.py:639 forward → _forward_impl (matching…#16727chenfeiz0326 wants to merge 1 commit into
forward → _forward_impl (matching…#16727chenfeiz0326 wants to merge 1 commit into
Conversation
…rward_impl MTPEagleDynamicTreeWorker (added by NVIDIA#15582) overrode SpecWorkerBase.forward, which the __init_subclass__ guard (nvbugs/6442074) forbids. This raised a TypeError at import time, breaking all pytest collection. Rename the method to _forward_impl, matching the MTPWorker pattern, so the base forward wrapper provides the guaranteed spec-dec attn-metadata cleanup. Signed-off-by: Chenfei Zhang <chenfeiz@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe dynamic-tree worker’s top-level method is renamed from ChangesDynamic tree entry point
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Jul 22, 2026
[https://nvbugs/6464169][fix] Rename
forward → _forward_impl (signature unchanged); the base…
#16728
Open
Open
Collaborator
|
Duplicated with #16724 |
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forward→_forward_impl(matching MTPWorker), letting the base SpecWorkerBase.forward wrapper provide the cleanup finally block; staged ONLY that one file to avoid the LFS-blob corruption that rejected both prior attempts.Test plan
Links
Dev Engineer Review
MTPEagleDynamicTreeWorker.forwardto_forward_implto comply with theSpecWorkerBase.__init_subclass__guard.SpecWorkerBase.forwardwrapper to handle spec-dec attention-metadata cleanup and restores pytest collection.QA Engineer Review
No test changes.