[https://nvbugs/6478715][fix] Renamed the worker's forward() to _forward_impl() so the base…#16730
Open
chenfeiz0326 wants to merge 1 commit into
Open
[https://nvbugs/6478715][fix] Renamed the worker's forward() to _forward_impl() so the base…#16730chenfeiz0326 wants to merge 1 commit into
chenfeiz0326 wants to merge 1 commit into
Conversation
…rward_impl MTPEagleDynamicTreeWorker overrode SpecWorkerBase.forward, which the __init_subclass__ guard (nvbugs/6442074) forbids, raising TypeError at import time and breaking test collection. Rename to _forward_impl so the base SpecWorkerBase.forward wrapper drives it and retains its attn-metadata cleanup guarantee. Signed-off-by: Chenfei Zhang <chenfeiz@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe MTP dynamic tree worker’s top-level method is renamed from ChangesMTP dynamic tree worker
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Links
Dev Engineer Review
MTPEagleDynamicTreeWorker.forward()to_forward_impl()soSpecWorkerBasecan retain control of the guardedforward()wrapper and perform attention-metadata cleanup.QA Engineer Review
No test changes.