Skip to content

[https://nvbugs/6445316][fix] Renamed the worker's forward method to _forward_impl (matching every sibling… - #16731

Open
chenfeiz0326 wants to merge 1 commit into
NVIDIA:mainfrom
chenfeiz0326:repair-bot-bug6445316
Open

[https://nvbugs/6445316][fix] Renamed the worker's forward method to _forward_impl (matching every sibling…#16731
chenfeiz0326 wants to merge 1 commit into
NVIDIA:mainfrom
chenfeiz0326:repair-bot-bug6445316

Conversation

@chenfeiz0326

@chenfeiz0326 chenfeiz0326 commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Root cause: MTPEagleDynamicTreeWorker overrode SpecWorkerBase.forward, which init_subclass forbids, raising TypeError at import and breaking all test collection.
  • Fix: Renamed the worker's forward method to _forward_impl (matching every sibling worker); committed ONLY the single file to avoid prior LFS scope-creep.
  • Automated fix generated by repair-bot

Test plan

  • Verify fix on the same GPU type as the original failure
  • Check for regressions in related tests

Links

Dev Engineer Review

  • Renamed MTPEagleDynamicTreeWorker.forward to _forward_impl without changing its signature, implementation, or NVTX decorator.
  • Resolves the import-time TypeError enforced by SpecWorkerBase.__init_subclass__.
  • Scope is limited to the intended single-line method rename; no configuration, test-list, or unrelated API changes.

QA Engineer Review

  • No test changes.

Signed-off-by: Chenfei Zhang <chenfeiz@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e6fbf5ff-7b19-4b27-813f-5710f144c92c

📥 Commits

Reviewing files that changed from the base of the PR and between 9cd6a49 and 37c6bc8.

📒 Files selected for processing (1)
  • tensorrt_llm/_torch/speculative/mtp_dynamic_tree.py

Walkthrough

Renames MTPEagleDynamicTreeWorker.forward to _forward_impl while preserving its parameters, implementation body, and NVTX decorator.

Changes

Dynamic tree worker entrypoint

Layer / File(s) Summary
Rename worker entrypoint
tensorrt_llm/_torch/speculative/mtp_dynamic_tree.py
The decorated worker method is renamed from forward to _forward_impl without changing its signature or body.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: sunnyqgg

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: renaming MTPEagleDynamicTreeWorker.forward to _forward_impl to fix the import-time TypeError.
Description check ✅ Passed It includes a summary, test plan, and bug link; only the template's explicit Description section and checklist are missing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@cascade812 cascade812 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is duplicated with #16728 Same issue has been fixed by #16724.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants