Skip to content

[https://nvbugs/6474892][fix] Rename MTPEagleDynamicTreeWorker.forward → _forward_impl (signature unchanged…#16735

Closed
chenfeiz0326 wants to merge 1 commit into
NVIDIA:mainfrom
chenfeiz0326:repair-bot-bug6474892
Closed

[https://nvbugs/6474892][fix] Rename MTPEagleDynamicTreeWorker.forward → _forward_impl (signature unchanged…#16735
chenfeiz0326 wants to merge 1 commit into
NVIDIA:mainfrom
chenfeiz0326:repair-bot-bug6474892

Conversation

@chenfeiz0326

@chenfeiz0326 chenfeiz0326 commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Root cause: MTPEagleDynamicTreeWorker overrode SpecWorkerBase.forward, which SpecWorkerBase.init_subclass forbids, raising TypeError at import time and breaking pytest collection for every test importing tensorrt_llm.
  • Fix: Rename MTPEagleDynamicTreeWorker.forward → _forward_impl (signature unchanged, compatible with base's *args/**kwargs dispatch); committed ONLY that source file to avoid the prior LFS-binary pollution.
  • Automated fix generated by repair-bot

Test plan

  • Verify fix on the same GPU type as the original failure
  • Check for regressions in related tests

Links

Dev Engineer Review

  • Renamed MTPEagleDynamicTreeWorker.forward to _forward_impl without changing its signature or behavior.
  • Resolves SpecWorkerBase.__init_subclass__ import-time validation failures and restores pytest collection.
  • No configuration, test-list, or unrelated files were changed.

QA Engineer Review

No test changes.

…orker

Signed-off-by: Chenfei Zhang <chenfeiz@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

MTPEagleDynamicTreeWorker.forward(...) is renamed to _forward_impl(...); its parameters and implementation remain unchanged.

Changes

Dynamic tree execution

Layer / File(s) Summary
Rename worker execution entry point
tensorrt_llm/_torch/speculative/mtp_dynamic_tree.py
Renames the worker’s main execution method from forward to _forward_impl without changing its parameters or pipeline logic.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: sunnyqgg

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description summarizes the fix and test plan, but it does not follow the required template and omits the PR Checklist section. Rewrite it using the repository template with @coderabbitai summary, Description, Test Coverage, and PR Checklist sections.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the change and follows the required ticket/type pattern.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant