[https://nvbugs/6468821][fix] Rename the dynamic-tree worker's forward override to _forward_impl… - #16741
Closed
chenfeiz0326 wants to merge 1 commit into
Closed
[https://nvbugs/6468821][fix] Rename the dynamic-tree worker's forward override to _forward_impl…#16741chenfeiz0326 wants to merge 1 commit into
forward override to _forward_impl…#16741chenfeiz0326 wants to merge 1 commit into
Conversation
…ard_impl MTPEagleDynamicTreeWorker overrode SpecWorkerBase.forward, which __init_subclass__ forbids (the base forward guarantees spec-dec attn-metadata cleanup, nvbugs/6442074). The TypeError raised at class definition broke 'import tensorrt_llm', so unrelated tests collected 0 items. Rename the override to _forward_impl to match the contract. Signed-off-by: Chenfei Zhang <chenfeiz@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Walkthrough
ChangesDynamic tree worker entry point
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
zhaoyangwang-nvidia
approved these changes
Jul 23, 2026
Collaborator
|
The same fix #16724 has been merged, close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import tensorrt_llmfail so the attention test collected 0 items.forwardoverride to_forward_impl, matching the SpecWorkerBase contract and its parent MTPEagleWorker._forward_impl, so the baseforwardwrapper (with metadata cleanup) is preserved.Test plan
Links
Dev Engineer Review
MTPEagleDynamicTreeWorker.forward(...)to_forward_impl(...)without changing its signature or implementation.SpecWorkerBasecontract and the existingMTPEagleWorkerpattern, preventing the import-timeTypeErrorwhile preserving base-wrapper metadata cleanup.QA Engineer Review
No test changes.