[https://nvbugs/6485390][fix] Fix Qwen disagg throughput regression by restoring MTP forward hook - #16740
Closed
trtllm-agent wants to merge 1 commit into
Closed
[https://nvbugs/6485390][fix] Fix Qwen disagg throughput regression by restoring MTP forward hook#16740trtllm-agent wants to merge 1 commit into
trtllm-agent wants to merge 1 commit into
Conversation
Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
trtllm-agent
requested review from
Tabrizian,
dhansen-nvidia,
nv-ananjappa and
pcastonguay
July 22, 2026 14:46
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
WalkthroughThe dynamic-tree worker entry method is renamed to ChangesDynamic tree worker entrypoint
NIXL cache transceiver configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Jul 22, 2026
Collaborator
|
@nv-xtf Please pay attention to the GPT-OSS perf regression case here. Thanks! |
Shixiaowei02
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MTPEagleDynamicTreeWorker.forwardmethod was overriding the parentMTPEagleWorker.forward, which bypassed the standard entry-point wrapping (NVTX/profiling and dispatch hooks) used by the base worker path. This caused the dynamic-tree MTP worker to take a slower code path on Qwen disaggregated runs, producing a measurable Total_Token_Throughput regression versus 1.3.0rc15. Additionally, the disaggregated GPT-OSS perf-sanity YAML pinnedtransceiver_runtime: PYTHON, forcing the slower Python NIXL transceiver instead of the optimized default._forward_implso the parent class'sforwardremains the single entry point and correctly dispatches into the dynamic-tree implementation, restoring the fast path used prior to rc15. The two perf-sanity YAMLs were updated to drop thetransceiver_runtime: PYTHONoverride so the default (faster) transceiver runtime is used, aligning benchmark configuration with production defaults.Test plan
Links
Dev Engineer Review
MTPEagleDynamicTreeWorker.forwardto_forward_implwithout changing its signature or implementation, preserving the parent worker’s standardforwardentry point and associated hooks.transceiver_runtime: PYTHONoverrides from the GPT-OSS performance-sanity configurations so they use the default optimized runtime.QA Engineer Review
No test changes.