Skip to content

[https://nvbugs/6479324][test] Waive 1 failed test - #16885

Closed
VALLIS-NERIA wants to merge 1 commit into
NVIDIA:mainfrom
VALLIS-NERIA:agent/nvbug-6479324-revert-waiver
Closed

[https://nvbugs/6479324][test] Waive 1 failed test#16885
VALLIS-NERIA wants to merge 1 commit into
NVIDIA:mainfrom
VALLIS-NERIA:agent/nvbug-6479324-revert-waiver

Conversation

@VALLIS-NERIA

@VALLIS-NERIA VALLIS-NERIA commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Description

Reverts #16878. NVBug 6479324 is not actually fixed yet, so removing its waiver was premature and re-enables a failing test. This restores the waiver entry:

full:H100/disaggregated/test_disaggregated.py::test_disaggregated_stress_test[input8k-output1k-conc512-qwen3_5_4b_fp8_stress] SKIP (https://nvbugs/6479324)

Test Coverage

Re-adds the SKIP waiver so test_disaggregated_stress_test[input8k-output1k-conc512-qwen3_5_4b_fp8_stress] is skipped again until NVBug 6479324 is genuinely fixed.

PR Checklist

  • PR title follows [NVBUG][type] description format
  • Pure revert of the waiver removal; no source behavior change

🤖 Generated with Claude Code

Dev Engineer Review

  • Restores the waiver for the H100 disaggregated stress-test variant due to NVBug 6479324.
  • The waiver entry is correctly scoped and introduces no source or public API changes.
  • No duplicate or unintended configuration changes were identified.

QA Engineer Review

  • Test-list-only change: added the affected test to tests/integration/test_lists/waives.txt.
  • No test-db/ or qa/ files were modified.
  • Verdict: needs follow-up because CBTS coverage data is unavailable.

…ed (By Agent)

Signed-off-by: Xiwen Yu <13230610+VALLIS-NERIA@users.noreply.github.com>
@VALLIS-NERIA

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Adds a skipped-test waiver for the H100 disaggregated stress-test configuration input8k-output1k-conc512-qwen3_5_4b_fp8_stress, linked to NVBug 6479324.

Changes

Integration test waiver

Layer / File(s) Summary
Add disaggregated stress-test waiver
tests/integration/test_lists/waives.txt
Adds a SKIP waiver for the specified disaggregated stress-test variant with an NVBug 6479324 reference.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: brnguyen2

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is concise and clearly refers to the waiver restore for NVBug 6479324 and the failed test.
Description check ✅ Passed The PR includes Description, Test Coverage, and PR Checklist sections with relevant details for the waiver restore.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@VALLIS-NERIA VALLIS-NERIA changed the title [https://nvbugs/6479324][test] Revert #16878: restore waiver, bug not yet fixed [https://nvbugs/6479324][test] Waive 1 failed test Jul 27, 2026
@VALLIS-NERIA

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61803 [ run ] triggered by Bot. Commit: 3ae8578 Link to invocation

@VALLIS-NERIA
VALLIS-NERIA enabled auto-merge (squash) July 27, 2026 04:04
@VALLIS-NERIA
VALLIS-NERIA disabled auto-merge July 27, 2026 04:09
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61804 [ run ] triggered by Bot. Commit: 3ae8578 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61803 [ run ] completed with state ABORTED. Commit: 3ae8578

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61804 [ run ] completed with state SUCCESS. Commit: 3ae8578
/LLM/main/L0_MergeRequest_PR pipeline #50003 completed with status: 'SUCCESS'

CI Report

Link to invocation

@BowenFu BowenFu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact revert of #16878 — restores the waiver whose removal was premature since nvbugs/6479324 isn't actually fixed. Verified the line is absent from main (no duplicate) and the hunk is byte-identical to #16878's inverse. Test-list only, no source change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants