Skip to content

[None][fix] Clarify explicit post-merge stage CI label - #16886

Merged
yibinl-nvidia merged 2 commits into
NVIDIA:mainfrom
yibinl-nvidia:modifyci-overview-doc
Jul 27, 2026
Merged

[None][fix] Clarify explicit post-merge stage CI label#16886
yibinl-nvidia merged 2 commits into
NVIDIA:mainfrom
yibinl-nvidia:modifyci-overview-doc

Conversation

@yibinl-nvidia

@yibinl-nvidia yibinl-nvidia commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Clarified CI documentation for post-merge stage approval labels.
  • Explicitly selected stages no longer require ci: post-merge.
  • Broad wildcard selectors still require the approval label, including escaped or repeated-star variants.

Dev Engineer Review

  • Documentation-only change; wording is consistent with the described CI behavior.
  • No code, configuration, API, performance, or error-handling changes identified.
  • No apparent unintended scope changes.

QA Engineer Review

No test changes.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Yibin Li <109242046+yibinl-nvidia@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Clarifies when the ci: post-merge approval label is required for explicit and wildcard post-merge test selectors, including comma-separated and escaped or repeated-star variants.

Changes

Post-merge test guidance

Layer / File(s) Summary
Selector approval rules
docs/source/developer-guide/ci-overview.md
Distinguishes explicit stage selections that do not require approval labels from wildcard selectors that do, while documenting equivalent selector variants and preserving existing behavior for other patterns.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: vallis-neria

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description keeps the template but leaves Description and Test Coverage empty, so it does not explain the change or validation. Fill in the Description and Test Coverage sections with a short summary of the issue, the fix, and any tests or verification performed.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the main change and uses the repository's required ticket/type format.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/source/developer-guide/ci-overview.md`:
- Around line 136-139: Update the approval-label reference in the CI overview
documentation to use the exact full name `ci: post-merge approved`, keeping the
surrounding selector behavior description unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5131203c-cd68-4da9-893c-264f2375db00

📥 Commits

Reviewing files that changed from the base of the PR and between da39470 and 5690c96.

📒 Files selected for processing (1)
  • docs/source/developer-guide/ci-overview.md

Comment thread docs/source/developer-guide/ci-overview.md
Signed-off-by: Yibin Li <109242046+yibinl-nvidia@users.noreply.github.com>
@yibinl-nvidia

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61921 [ run ] triggered by Bot. Commit: 736756b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61921 [ run ] completed with state SUCCESS. Commit: 736756b
/LLM/main/L0_MergeRequest_PR pipeline #50112 completed with status: 'SUCCESS'

CI Report

Link to invocation

@yibinl-nvidia
yibinl-nvidia merged commit 0f5e15e into NVIDIA:main Jul 27, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants