[TRTLLMINF-188][infra] Require approval for PerfSanity wildcard runs - #16777
Conversation
Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
|
/bot skip --comment "Not tested by L0" |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughUpdates ChangesPost-merge stage selector guidance
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8).github/workflows/bot-command.ymlTraceback (most recent call last): Comment |
|
PR_Github #61194 [ skip ] triggered by Bot. Commit: |
|
PR_Github #61194 [ skip ] completed with state |
…nnahz/dep-1083-port-flashinfer-stable-va-lifecycle-for-native-all-reduce * 'main' of https://github.com/NVIDIA/TensorRT-LLM: (83 commits) [None][feat] Bind SourceIdentity to checkpoint artifacts (NVIDIA#16159) [None][infra] Waive 4 failed cases for main in pre-merge 49550 (NVIDIA#16798) [None][fix] Make FlashInfer sampling op wrappers opaque to Dynamo (NVIDIA#16732) [None][feat] top-k: route decode to CuTe DSL GVR top-k in e2e (NVIDIA#16420) [None][feat] Default GLM-5 to the Python KV-cache transceiver (NVIDIA#16524) [None][chore] Add NVTX ranges to per-iteration ADP sync points in PyExecutor (NVIDIA#16422) [https://nvbugs/6426850][test] Unwaive Qwen3.5 397B NVFP4 ADP4 TRTLLM test (NVIDIA#16348) [https://nvbugs/6445456][fix] Restore inplace ops for functionalization v2 (NVIDIA#16410) [None][infra] Waive 1 failed cases for main in pre-merge 49229 (NVIDIA#16786) [None][fix] Load DeepSeek V4 mixed-precision NVFP4 checkpoints (NVIDIA#16433) [None][feat] ADP conversation router: configurable least-queued placement for new conversations (NVIDIA#16294) [None][infra] Waive 1 failed cases for main in pre-merge 49424 (NVIDIA#16780) [None][infra] Waive 1 failed cases for main in pre-merge 49424 (NVIDIA#16781) [TRTLLMINF-188][infra] Require approval for PerfSanity wildcard runs (NVIDIA#16777) [TRTLLM-13969][feat] Support MiniMax M3 for Disaggregated Serving (NVIDIA#16017) [NVIDIA#11932][fix] Filter CUTLASS MoE GEMM tile configs by device shared memory on SM121 (NVIDIA#12704) [None][chore] Remove attention backend test waivers (NVIDIA#16723) [TRTLLM-14540][perf] Skip fp32 state round-trip in FlashInfer GDN pre… (NVIDIA#16703) [TRTLLM-13694][feat] Add IBDB recipe provenance and refresh configs (NVIDIA#16254) [None][infra] Preview/bump/main (NVIDIA#16758) ... Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
…VIDIA#16777) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
Summary
Updated bot help and CI documentation to require the
ci: post-merge approvedlabel for*PerfSanity*selectors used with--stage-listor--extra-stage. Escaped, repeated-star, and comma-separated selector forms are documented consistently. Existing behavior for explicit stages, one-sided patterns, case variants, and other limited wildcards remains unchanged.Validation included YAML and embedded JavaScript parsing, selector-contract checks, and
git diff --check.Dev Engineer Review
QA Engineer Review
No test changes.
Description
The
"*PerfSanity*"selector can match multiple CI stages, but the existing approval guidance only covered"*"and"*Post-Merge*".This follow-up to TRTLLMINF-188 updates the bot help and CI documentation so
"*PerfSanity*"requires the sameci: post-merge approvedlabel for both--stage-listand--extra-stage. Equivalent escaped or repeated-star forms and comma-separated lists are covered by the coordinated CI wrapper change.Explicit stage names, one-sided patterns, case variants, and other limited wildcard selectors retain their existing behavior. The approval-label workflow itself is unchanged.
Test Coverage
.github/workflows/bot-command.ymlas YAML.github-scriptblock with Node.js.git diff --check.PR Checklist
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.