Skip to content

[TRTLLMINF-188][infra] Require approval for PerfSanity wildcard runs - #16777

Merged
chzblych merged 1 commit into
NVIDIA:mainfrom
chzblych:trtllminf-188-perfsanity-wildcard-approval
Jul 23, 2026
Merged

[TRTLLMINF-188][infra] Require approval for PerfSanity wildcard runs#16777
chzblych merged 1 commit into
NVIDIA:mainfrom
chzblych:trtllminf-188-perfsanity-wildcard-approval

Conversation

@chzblych

@chzblych chzblych commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

Updated bot help and CI documentation to require the ci: post-merge approved label for *PerfSanity* selectors used with --stage-list or --extra-stage. Escaped, repeated-star, and comma-separated selector forms are documented consistently. Existing behavior for explicit stages, one-sided patterns, case variants, and other limited wildcards remains unchanged.

Validation included YAML and embedded JavaScript parsing, selector-contract checks, and git diff --check.

Dev Engineer Review

  • Documentation and bot help are consistent.
  • No workflow logic, approval-label behavior, APIs, or runtime code were changed.
  • No test-list files or configuration scope changes were introduced.
  • Verdict: sufficient.

QA Engineer Review

No test changes.

Description

The "*PerfSanity*" selector can match multiple CI stages, but the existing approval guidance only covered "*" and "*Post-Merge*".

This follow-up to TRTLLMINF-188 updates the bot help and CI documentation so "*PerfSanity*" requires the same ci: post-merge approved label for both --stage-list and --extra-stage. Equivalent escaped or repeated-star forms and comma-separated lists are covered by the coordinated CI wrapper change.

Explicit stage names, one-sided patterns, case variants, and other limited wildcard selectors retain their existing behavior. The approval-label workflow itself is unchanged.

Test Coverage

  • Parsed .github/workflows/bot-command.yml as YAML.
  • Parsed the embedded bot-help github-script block with Node.js.
  • Validated the coordinated selector contract for both flags, escaped and repeated-star forms, comma-separated lists, and unchanged limited selectors.
  • Ran git diff --check.

PR Checklist

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
@chzblych
chzblych marked this pull request as ready for review July 23, 2026 05:12
@chzblych
chzblych requested review from a team as code owners July 23, 2026 05:12
@chzblych

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Not tested by L0"

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 53d3de8f-8117-4238-8edc-f177f0ddc8e3

📥 Commits

Reviewing files that changed from the base of the PR and between 0a401b4 and 5e35668.

📒 Files selected for processing (2)
  • .github/workflows/bot-command.yml
  • docs/source/developer-guide/ci-overview.md

Walkthrough

Updates /bot run help text and CI documentation to clarify wildcard stage selectors, including *PerfSanity*, and the ci: post-merge approved label requirement for comma-separated, escaped, and repeated-star forms.

Changes

Post-merge stage selector guidance

Layer / File(s) Summary
Wildcard selector and label documentation
.github/workflows/bot-command.yml, docs/source/developer-guide/ci-overview.md
Bot help and CI documentation now include *PerfSanity* and clarify approval-label requirements for comma-separated, escaped, and repeated-star selector forms.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: wanli-jiang

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the PR format and clearly describes the main change: requiring approval for PerfSanity wildcard runs.
Description check ✅ Passed The description includes the required summary, description, test coverage, checklist, and bot help sections with substantive details.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)
.github/workflows/bot-command.yml

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'


Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61194 [ skip ] triggered by Bot. Commit: 5e35668 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61194 [ skip ] completed with state SUCCESS. Commit: 5e35668
Skipping testing for commit 5e35668

Link to invocation

@chzblych
chzblych merged commit 3d86c72 into NVIDIA:main Jul 23, 2026
13 checks passed
@chzblych
chzblych deleted the trtllminf-188-perfsanity-wildcard-approval branch July 23, 2026 05:55
hhzhang16 added a commit to hhzhang16/TensorRT-LLM that referenced this pull request Jul 23, 2026
…nnahz/dep-1083-port-flashinfer-stable-va-lifecycle-for-native-all-reduce

* 'main' of https://github.com/NVIDIA/TensorRT-LLM: (83 commits)
  [None][feat] Bind SourceIdentity to checkpoint artifacts (NVIDIA#16159)
  [None][infra] Waive 4 failed cases for main in pre-merge 49550 (NVIDIA#16798)
  [None][fix] Make FlashInfer sampling op wrappers opaque to Dynamo (NVIDIA#16732)
  [None][feat] top-k: route decode to CuTe DSL GVR top-k in e2e (NVIDIA#16420)
  [None][feat] Default GLM-5 to the Python KV-cache transceiver (NVIDIA#16524)
  [None][chore] Add NVTX ranges to per-iteration ADP sync points in PyExecutor (NVIDIA#16422)
  [https://nvbugs/6426850][test] Unwaive Qwen3.5 397B NVFP4 ADP4 TRTLLM test (NVIDIA#16348)
  [https://nvbugs/6445456][fix] Restore inplace ops for functionalization v2 (NVIDIA#16410)
  [None][infra] Waive 1 failed cases for main in pre-merge 49229 (NVIDIA#16786)
  [None][fix] Load DeepSeek V4 mixed-precision NVFP4 checkpoints (NVIDIA#16433)
  [None][feat] ADP conversation router: configurable least-queued placement for new conversations (NVIDIA#16294)
  [None][infra] Waive 1 failed cases for main in pre-merge 49424 (NVIDIA#16780)
  [None][infra] Waive 1 failed cases for main in pre-merge 49424 (NVIDIA#16781)
  [TRTLLMINF-188][infra] Require approval for PerfSanity wildcard runs (NVIDIA#16777)
  [TRTLLM-13969][feat] Support MiniMax M3 for Disaggregated Serving (NVIDIA#16017)
  [NVIDIA#11932][fix] Filter CUTLASS MoE GEMM tile configs by device shared memory on SM121 (NVIDIA#12704)
  [None][chore] Remove attention backend test waivers (NVIDIA#16723)
  [TRTLLM-14540][perf] Skip fp32 state round-trip in FlashInfer GDN pre… (NVIDIA#16703)
  [TRTLLM-13694][feat] Add IBDB recipe provenance and refresh configs (NVIDIA#16254)
  [None][infra] Preview/bump/main (NVIDIA#16758)
  ...

Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
yuanjingx87 pushed a commit to yuanjingx87/TensorRT-LLM that referenced this pull request Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants