Skip to content

[https://nvbugs/6255417][fix] Unwaive qwen3next ci test - #16924

Open
JadoTu wants to merge 2 commits into
NVIDIA:mainfrom
JadoTu:unwaive_bug_6255417
Open

[https://nvbugs/6255417][fix] Unwaive qwen3next ci test#16924
JadoTu wants to merge 2 commits into
NVIDIA:mainfrom
JadoTu:unwaive_bug_6255417

Conversation

@JadoTu

@JadoTu JadoTu commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Removed the SKIP waiver entry for accuracy/test_llm_api_pytorch.py::TestQwen3NextInstruct::test_bf16_4gpu[tep4] associated with NVBug 6255417 from tests/integration/test_lists/waives.txt.
  • Change is correctly scoped to the waiver list only (no code/config changes).
  • Waiver formatting remains consistent and the entry removal is the only modification in the file.

QA Engineer Review

  • Modified files:
    • tests/integration/test_lists/waives.txt: removed 1 SKIP waiver line for accuracy/test_llm_api_pytorch.py::TestQwen3NextInstruct::test_bf16_4gpu[tep4] (NVBug 6255417); no replacement entry added.
  • Verdict: needs follow-up — CBTS coverage data is unavailable.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: jiant <107457950+JadoTu@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f943de7a-879a-4a07-930e-027717738f6b

📥 Commits

Reviewing files that changed from the base of the PR and between 1494c86 and 7b002a6.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
🚧 Files skipped from review as they are similar to previous changes (1)
  • tests/integration/test_lists/waives.txt

Walkthrough

Removes the waiver entry for TestQwen3NextInstruct::test_bf16_4gpu[tep4] from the integration waiver list.

Changes

Integration waiver update

Layer / File(s) Summary
Remove Qwen3 test waiver
tests/integration/test_lists/waives.txt
Deletes the SKIP waiver linked to nvbugs 6255417 for the Qwen3 Next Instruct BF16 4-GPU test.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: dpitman-nvda, stanleysun639

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is largely incomplete because it omits the required Description and Test Coverage sections. Add a short Description of the issue and fix, plus a Test Coverage section listing the relevant tests or CI validation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the change: it references NVBug 6255417 and unwaiving the Qwen3Next CI test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@JadoTu

JadoTu commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62068 [ run ] triggered by Bot. Commit: 7b002a6 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62068 [ run ] completed with state SUCCESS. Commit: 7b002a6
/LLM/main/L0_MergeRequest_PR pipeline #50253 completed with status: 'SUCCESS'

CI Report

Link to invocation

@JadoTu
JadoTu enabled auto-merge (squash) July 28, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants