Skip to content

[None][test] Waive failed unittest on all devices (nvbugs/6335726)#15585

Merged
xxi-nv merged 1 commit into
NVIDIA:mainfrom
guqiqi:20260624-waivetest
Jun 25, 2026
Merged

[None][test] Waive failed unittest on all devices (nvbugs/6335726)#15585
xxi-nv merged 1 commit into
NVIDIA:mainfrom
guqiqi:20260624-waivetest

Conversation

@guqiqi

@guqiqi guqiqi commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description

Waive unittest unittest/llmapi/test_llm_pytorch.py::test_qwen_moe_routed_expert_multi_lora_varying_ranks (SKIP), tracked by nvbugs/6335726.

Summary by CodeRabbit

  • Tests
    • Adjusted integration test waivers for one model-routing test, updating where the skip applies during test runs.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

In tests/integration/test_lists/waives.txt, the SKIP waiver for test_qwen_moe_routed_expert_multi_lora_varying_ranks is removed from the full:H100_PCIe/unittest/llmapi/ prefixed entry and re-added as an unprefixed unittest/llmapi/ entry.

Changes

Waiver scope reassignment

Layer / File(s) Summary
Waiver scope reassignment
tests/integration/test_lists/waives.txt
Removes the full:H100_PCIe/-prefixed SKIP waiver for test_qwen_moe_routed_expert_multi_lora_varying_ranks (line 216) and adds an unprefixed SKIP waiver for the same test under unittest/llmapi/ (line 453), broadening the skip scope beyond a single hardware target.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • StanleySun639
  • jieli-matrix
  • crazydemo
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is too incomplete: it lacks the required title format, test coverage, and checklist sections from the template. Add the template sections, especially a properly formatted title, a short issue/solution description, and relevant test coverage details.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main change: waiving a failed unittest across all devices.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@guqiqi
guqiqi marked this pull request as draft June 24, 2026 09:39
@guqiqi
guqiqi marked this pull request as ready for review June 24, 2026 09:40
@guqiqi guqiqi changed the title [None][CI] Waive failed unittest on all devices (nvbugs/6357628) [None][CI] Waive failed unittest on all devices (nvbugs/6335726) Jun 24, 2026
@guqiqi guqiqi changed the title [None][CI] Waive failed unittest on all devices (nvbugs/6335726) [None][test] Waive failed unittest on all devices (nvbugs/6335726) Jun 24, 2026
@guqiqi

guqiqi commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

/bot skip --comment "skip to waive the flaky test"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55480 [ skip ] triggered by Bot. Commit: 4126199 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55480 [ skip ] completed with state SUCCESS. Commit: 4126199
Skipping testing for commit 4126199

Link to invocation

Signed-off-by: guqiqi <29116997+guqiqi@users.noreply.github.com>
@guqiqi
guqiqi force-pushed the 20260624-waivetest branch from 2c0b257 to d805091 Compare June 24, 2026 12:50
@xxi-nv

xxi-nv commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

/bot skip --comment "skip to waive the flaky test"

@xxi-nv
xxi-nv enabled auto-merge (squash) June 25, 2026 01:48
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55650 [ skip ] triggered by Bot. Commit: d805091 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55650 [ skip ] completed with state SUCCESS. Commit: d805091
Skipping testing for commit d805091

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants