[None][infra] Waive 1 failed cases for main in pre-merge 50457 - #16978
Merged
JunyiXu-nv merged 1 commit intoJul 29, 2026
Merged
Conversation
Bug(s): 6529626 Requested by: @JunyiXu-nv Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
trtllm-agent
requested review from
BowenFu,
LarryXFly,
QiJune,
StanleySun639,
mlefeb01 and
mzweilz
July 29, 2026 01:49
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughAdds an NVBug-linked SKIP waiver for ChangesIntegration Test Waiver
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
yiqingy0
approved these changes
Jul 29, 2026
Collaborator
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #62369 [ run ] triggered by Bot. Commit: |
2 tasks
Collaborator
|
PR_Github #62369 [ run ] completed with state |
This was referenced Jul 29, 2026
JunyiXu-nv
added a commit
to JunyiXu-nv/TensorRT-LLM
that referenced
this pull request
Jul 29, 2026
…ng tests mcp is unpinned, and mcp 2.0.0 (published 2026-07-28 13:45 UTC) removed mcp.server.fastmcp: the package ships 19 files under mcp/server/fastmcp/ in 1.29.0 and none in 2.0.0. Any image built after that resolves the bare requirement to 2.0.0, so the module-level import in tests/unittest/scaffolding/test_mcp_worker.py raises while pytest is collecting it. A collection error is not a test failure. pytest reports "Interrupted: 1 error during collection" and exits 2 before running anything, so the other seven files in tests/unittest/scaffolding never execute and no JUnit report is written at all -- which is why this surfaced only as the outer wrapper's "assert passed, failure reported in unittests", with no inner test named anywhere in the archived stage results. Nor could it be waived at test granularity: apply_waives and apply_waives_ut both run inside pytest_collection_modifyitems and mark collected items, and a module that fails to import produces none. NVIDIA#16978 therefore waived the whole unittest/scaffolding directory as an interim unblock. Pin rather than skip the test. tensorrt_llm/scaffolding/worker.py and tensorrt_llm/scaffolding/contrib/mcp/mcp_utils.py both ship against the 1.x API, and test_mcp_worker.py is the only CI coverage that exercises MCPWorker against the installed mcp. Skipping it would drop that coverage precisely when the dependency took a major version bump, hiding a library-level risk rather than resolving it. With the pin in place the collection error is gone, so NVIDIA#16978's waive is removed in the same change: leaving it would keep all eight scaffolding files skipped indefinitely for a cause that no longer exists. Lifting the pin means migrating the library off the 1.x APIs first, not just the test. Signed-off-by: JunyiXu-nv <219237550+JunyiXu-nv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @JunyiXu-nv)
Target branch:
mainBug(s): 6529626
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Dev Engineer Review
SKIPwaiver forfull:DGX_H100/unittest/scaffolding.6529626.QA Engineer Review
tests/integration/test_lists/waives.txt.test-db/orqa/files were modified; the related H100 test-db entry remains present.