Skip to content

[None][test] Waive 1 failed cases for main in QA CI - #17044

Merged
jieli-matrix merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260730-044733
Jul 30, 2026
Merged

[None][test] Waive 1 failed cases for main in QA CI#17044
jieli-matrix merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260730-044733

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by qa@nvidia.com)
Target branch: main
Bug(s): 6523809

Waive entries added

full:H100/accuracy/test_llm_api_pytorch.py::TestQwen3_30B_A3B_Instruct_2507::test_skip_softmax_attention_4gpus[target_sparsity_0.9-fp8kv=False] SKIP (https://nvbugs/6523809)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Dev Engineer Review

  • Added one correctly formatted SKIP waiver in tests/integration/test_lists/waives.txt.
  • The waiver targets the specified test and references bug 6523809.
  • No code, API, performance, or error-handling changes; no apparent scope expansion or duplicate waiver.

QA Engineer Review

  • Test-list-only change; no test-db or QA files were modified.
  • Added one CI waiver entry for the specified Qwen3 H100 accuracy test.
  • Verdict: needs follow-up because CBTS coverage data is unavailable.

Bug(s): 6523809
Requested by: qa@nvidia.com

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@jieli-matrix
jieli-matrix enabled auto-merge (squash) July 30, 2026 04:48
@jieli-matrix

Copy link
Copy Markdown
Collaborator

/bot skip --comment "Only waive tests"

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

A new SKIP waiver entry excludes a specific H100 Qwen3 30B instruct integration test parameterization from integration runs and references the associated nvbug.

Changes

Integration test waiver

Layer / File(s) Summary
Add Qwen3 test waiver
tests/integration/test_lists/waives.txt
Adds a SKIP entry for the specified H100 Qwen3 30B instruct accuracy test parameterization with its nvbug reference.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: xinhe-nv, qijune, bowenfu

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is missing the required template sections for Description, Test Coverage, and PR Checklist. Reformat the PR body to match the repo template and add Description, Test Coverage, and PR Checklist sections with brief details.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is related to the PR's waiver change and mentions QA CI on main.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 245: Add the repository-standard NVIDIA copyright header at the top of
tests/integration/test_lists/waives.txt, updating the copyright year to 2026
while preserving the existing waiver entry.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 66e71ef1-0919-43a5-bea8-23d4f3cdf2f7

📥 Commits

Reviewing files that changed from the base of the PR and between c0df3b3 and 9f5881c.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Comment thread tests/integration/test_lists/waives.txt
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62699 [ skip ] triggered by Bot. Commit: 9f5881c Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62699 [ skip ] completed with state SUCCESS. Commit: 9f5881c
Skipping testing for commit 9f5881c

Link to invocation

@fredricz-20070104 fredricz-20070104 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary - Approve

Reviewed the full diff; no blocking or major issues found.

Minor, non-blocking notes:

  • tests/integration/test_lists/waives.txt: CodeRabbit copyright-header suggestion is not applicable

Automated review by NVCortex Lite, run by @fredricz-20070104.

@jieli-matrix
jieli-matrix merged commit 787ee94 into NVIDIA:main Jul 30, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants