Skip to content

[https://nvbugs/6487836][chore] unwaive test_performance_alignment[1] - #17066

Merged
tburt-nv merged 1 commit into
NVIDIA:mainfrom
tburt-nv:user/tburt/unwaive
Jul 30, 2026
Merged

[https://nvbugs/6487836][chore] unwaive test_performance_alignment[1]#17066
tburt-nv merged 1 commit into
NVIDIA:mainfrom
tburt-nv:user/tburt/unwaive

Conversation

@tburt-nv

@tburt-nv tburt-nv commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Description

It looks like this one was legitimately failing on multiple PRs at the same time after passing consistently, rather than having a new flakiness issue.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Dev Engineer Review

  • Removed the SKIP waiver for unittest/tools/test_layer_wise_benchmarks.py::test_performance_alignment[1] under NVBugs 6487836.
  • The change is correctly scoped to tests/integration/test_lists/waives.txt and preserves the surrounding test-list format.
  • No code, API, configuration, or performance changes were introduced.

QA Engineer Review

  • Modified tests/integration/test_lists/waives.txt by removing the test_performance_alignment[1] waiver entry.
  • No test-db or QA coverage files were modified.
  • Verdict: needs follow-up because CBTS coverage data is unavailable.

Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>
@tburt-nv
tburt-nv requested review from a team as code owners July 30, 2026 14:42
@tburt-nv

Copy link
Copy Markdown
Collaborator Author

/bot run

@tburt-nv
tburt-nv enabled auto-merge (squash) July 30, 2026 14:43
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2585a8d5-2c14-49b0-b56d-e810d3c7d113

📥 Commits

Reviewing files that changed from the base of the PR and between 01a04f0 and 6becc2e.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Walkthrough

Removed the test_performance_alignment[1] skip entry from the integration waiver list.

Changes

Integration waiver cleanup

Layer / File(s) Summary
Remove obsolete test waiver
tests/integration/test_lists/waives.txt
Deletes the test_layer_wise_benchmarks.py::test_performance_alignment[1] SKIP entry. Subsequent waiver entries shift upward.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: fredricz-20070104

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the change and includes the required ticket and type.
Description check ✅ Passed It includes Description, Test Coverage, and PR Checklist sections, but Test Coverage is still a placeholder.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62787 [ run ] triggered by Bot. Commit: 6becc2e Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62787 [ run ] completed with state SUCCESS. Commit: 6becc2e
/LLM/main/L0_MergeRequest_PR pipeline #50915 completed with status: 'SUCCESS'

CI Report

Link to invocation

@tburt-nv
tburt-nv merged commit b8a4af1 into NVIDIA:main Jul 30, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants