[https://nvbugs/6525898][fix] Append a constraint of _max_resident_sequences() + reserved-dummy… - #17071
Open
trtllm-agent wants to merge 1 commit into
Open
[https://nvbugs/6525898][fix] Append a constraint of _max_resident_sequences() + reserved-dummy…#17071trtllm-agent wants to merge 1 commit into
_max_resident_sequences() + reserved-dummy…#17071trtllm-agent wants to merge 1 commit into
Conversation
trtllm-agent
requested review from
BowenFu,
SimengLiu-nv,
brnguyen2,
jieli-matrix,
lowsfer,
yingguo-trt,
yiqingy0 and
yuanjingx87
July 30, 2026 15:50
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
Walkthrough
ChangesMamba SSM cache floor
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Jul 30, 2026
yingguo-trt
approved these changes
Jul 31, 2026
This was referenced Jul 31, 2026
MambaHybridCacheManagerV2.__init__ requires the SSM pool to hold one slot per resident lineage plus every reserved dummy slot. When avg_seq_len is unset, _build_base_config emits no constraints, so the storage manager received no min_slots floor for the SSM pool group; only the fallback typical_step steered the pool ratio. A ratio is not a floor, so the grain-based split rounded the SSM pool below the required count and initialization failed with 'The V2 Mamba state pool has only 31 slots but needs at least 34 live/dummy slots'. Emit the live/dummy slot count as an explicit constraint. The descriptors carry no capacity, so the attention pool floor is unchanged. Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
1 task
trtllm-agent
force-pushed
the
repair-bot-bug6525898
branch
from
July 31, 2026 17:44
8bc2e14 to
e68d27d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
avg_seq_lenunset no constraints are emitted, so the SSM pool group got nomin_slotsfloor and the ratio-based grain split rounded it to 31 slots, below the 34 live/dummy slots__init__requires._max_resident_sequences()+ reserved-dummy zero-capacityKVCacheDescs, which floors the SSM pool without adding attention pages.Test plan
Links
Dev Engineer Review
_num_required_state_slots().KVCacheDescconstraints for required live and dummy slots.avg_seq_lenis unset.QA Engineer Review
test_v2_hybrid_typical_batch_splits_capacity_across_ssm_states_and_dummies.test_v2_hybrid_constrains_ssm_pool_to_live_slot_floor.tests/integration/test_lists/for CI (test-db/) or manual QA (qa/) coverage.